Enable RTCVideoDecoder SW H264 fallback only when it is available

Enable RTCVideoDecoder SW H264 fallback only when it is available

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513
Committed: https://crrev.com/177cc1d1d66346ea9e2e85ecb3d6812e13b11907
Cr-Commit-Position: refs/heads/master@{#397856}

[emircan, 2016-06-01 18:15:02]

Description was changed from

==========
initialize ffmpeg when hw encode is available.

BUG=615513
==========

to

==========
Initialize FFmpeg when kEnableWebRtcHWH264Encoding is available

Extensions have kEnableWebRtcHWH264Encoding enabled in 51 to 
allow HW H264 encode. This corresponds to a HW H264 decode in 
some cases, but can always fall back to SW decode as well.
We need to initialize FFmpeg considering these cases.

BUG=615513
==========

[emircan, 2016-06-01 18:15:02]

emircan@chromium.org changed reviewers:
+ hbos@chromium.org, pbos@chromium.org

[emircan, 2016-06-02 02:42:31]

PTAL.

[hbos_chromium, 2016-06-02 08:45:37]

https://codereview.chromium.org/2024303003/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/2024303003/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:169:
kEnableWebRtcHWH264Encoding)) {
I don't think this is the right approach. If we're building with SW H264, one
feature unexpectedly enables another feature (that might be set to disabled
which is strange). If we're not building with SW H264 (such as chromium build
instead of a chrome official) this does not fix anything, we still have the
problem of trying to do SW fallback when SW is not available.

I'll continue the discussion at
https://bugs.chromium.org/p/chromium/issues/detail?id=615513

[emircan, 2016-06-02 20:54:18]

Description was changed from

==========
Initialize FFmpeg when kEnableWebRtcHWH264Encoding is available

Extensions have kEnableWebRtcHWH264Encoding enabled in 51 to 
allow HW H264 encode. This corresponds to a HW H264 decode in 
some cases, but can always fall back to SW decode as well.
We need to initialize FFmpeg considering these cases.

BUG=615513
==========

to

==========
Enable RTCVideoDecoder SW H264 fallback only when it is available

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513
==========

[emircan, 2016-06-02 20:54:32]

Updated the description as well.

https://codereview.chromium.org/2024303003/diff/1/content/renderer/media/webr...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/2024303003/diff/1/content/renderer/media/webr...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:169:
kEnableWebRtcHWH264Encoding)) {
On 2016/06/02 08:45:37, hbos_chromium wrote:
> I don't think this is the right approach. If we're building with SW H264, one
> feature unexpectedly enables another feature (that might be set to disabled
> which is strange). If we're not building with SW H264 (such as chromium build
> instead of a chrome official) this does not fix anything, we still have the
> problem of trying to do SW fallback when SW is not available.
> 
> I'll continue the discussion at
> https://bugs.chromium.org/p/chromium/issues/detail?id=615513

Done.

[pbos, 2016-06-03 08:10:41]

fwiw, lgtm

[hbos_chromium, 2016-06-03 08:22:05]

lgtm

[emircan, 2016-06-03 17:19:32]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-06-03 17:20:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024303003/20001

[commit-bot: I haz the power, 2016-06-03 17:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 17:27:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[emircan, 2016-06-03 21:18:44]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org

[emircan, 2016-06-03 21:18:45]

mcasas@chromium.org: Please review changes in PTAL.

[mcasas, 2016-06-03 21:20:09]

On 2016/06/03 21:18:45, emircan wrote:
> mailto:mcasas@chromium.org: Please review changes in PTAL.

RS LGTM

[emircan, 2016-06-03 21:26:02]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-06-03 21:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024303003/20001

[commit-bot: I haz the power, 2016-06-03 21:41:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 21:41:35]

Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[emircan, 2016-06-03 23:48:14]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-06-03 23:48:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024303003/20001

[commit-bot: I haz the power, 2016-06-04 00:35:56]

Description was changed from

==========
Enable RTCVideoDecoder SW H264 fallback only when it is available

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513
==========

to

==========
Enable RTCVideoDecoder SW H264 fallback only when it is available

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513
==========

[commit-bot: I haz the power, 2016-06-04 00:35:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-04 00:37:51]

Description was changed from

==========
Enable RTCVideoDecoder SW H264 fallback only when it is available

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513
==========

to

==========
Enable RTCVideoDecoder SW H264 fallback only when it is available

Extensions have HW H264 encode enabled in 51. However SW implementations
of H264 isn't enabled by default. So, we need to be careful about SW fallback
as we cannot do it when it isn't available.

BUG=615513

Committed: https://crrev.com/177cc1d1d66346ea9e2e85ecb3d6812e13b11907
Cr-Commit-Position: refs/heads/master@{#397856}
==========

[commit-bot: I haz the power, 2016-06-04 00:37:52]

Patchset 2 (id:??) landed as
https://crrev.com/177cc1d1d66346ea9e2e85ecb3d6812e13b11907
Cr-Commit-Position: refs/heads/master@{#397856}