Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024293005: Mark IntentUtils#safeGetBinderExtra() as VisibleForTesting to unbreak downstream tests (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark IntentUtils#safeGetBinderExtra() as VisibleForTesting to unbreak downstream tests BUG=616509 R=dfalcantara Committed: https://crrev.com/32d010818612c766d57b228faf589f7511468841 Cr-Commit-Position: refs/heads/master@{#397190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
dfalcantara@ PTAL
4 years, 6 months ago (2016-06-01 17:18:02 UTC) #1
gone
lgtm
4 years, 6 months ago (2016-06-01 17:32:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024293005/1
4 years, 6 months ago (2016-06-01 17:39:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 18:38:15 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 19:11:33 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/32d010818612c766d57b228faf589f7511468841
Cr-Commit-Position: refs/heads/master@{#397190}

Powered by Google App Engine
This is Rietveld 408576698