third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html - Issue 2024243002: Set default width/height of pointer events to 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html

Issue 2024243002: Set default width/height of pointer events to 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html b/third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html

index 620c34c9e2f5198f12f5b22592f1f6ac4cb19502..0b2ae15cfba3f30d9a65c22dfed32f6f3364d7c3 100644

--- a/third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html

+++ b/third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html

@@ -36,7 +36,10 @@ debug("--- tests for intrinsic attributes ---");

["width", "height", "pressure"].forEach(function (attr) {

debug("-- no init --");

- shouldBeZero("new PointerEvent('eventType')." + attr);

+ var defaultValue = 1; // For width and height

+ if (attr == "pressure")

+ defaultValue = 0;

+ shouldBeEqualToNumber("new PointerEvent('eventType')." + attr, defaultValue);

debug("-- init with valid float/double values --");

shouldBeEqualToNumber("new PointerEvent('eventType', { " + attr + ": 123 })." + attr, 123);

@@ -51,7 +54,7 @@ debug("--- tests for intrinsic attributes ---");

shouldThrow("new PointerEvent('eventType', { " + attr + ": 'dummy' })." + attr);

shouldThrow("new PointerEvent('eventType', { " + attr + ": NaN })." + attr);

shouldBeZero("new PointerEvent('eventType', { " + attr + ": null })." + attr);

- shouldBeZero("new PointerEvent('eventType', { " + attr + ": undefined })." + attr);

+ shouldBeEqualToNumber("new PointerEvent('eventType', { " + attr + ": undefined })." + attr, defaultValue);

shouldBeZero("new PointerEvent('eventType', { " + attr + ": [] })." + attr);

shouldBeEqualToNumber("new PointerEvent('eventType', { " + attr + ": [12] })." + attr, 12);