Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4123)

Unified Diff: chrome/browser/resources/md_user_manager/compiled_resources2.gyp

Issue 2024233003: MD User Manager: Refactors existing dialogs in User Manager into <user-manager-dialog> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md-user-manager-locked-test
Patch Set: Closure compiler target for the dialog Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/md_user_manager/create_profile.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_user_manager/compiled_resources2.gyp
diff --git a/chrome/browser/resources/md_user_manager/compiled_resources2.gyp b/chrome/browser/resources/md_user_manager/compiled_resources2.gyp
index d40c46d4ac1e751dbbe37d1278e9b0871ae0d933..a2526e9714fc79c1728a03fba0645f99c15cea2d 100644
--- a/chrome/browser/resources/md_user_manager/compiled_resources2.gyp
+++ b/chrome/browser/resources/md_user_manager/compiled_resources2.gyp
@@ -24,6 +24,9 @@
},
{
'target_name': 'error_dialog',
+ 'dependencies': [
+ 'user_manager_dialog'
+ ],
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
{
@@ -31,6 +34,7 @@
'dependencies': [
'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:i18n_behavior',
'profile_browser_proxy',
+ 'user_manager_dialog'
],
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
@@ -59,6 +63,10 @@
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
{
+ 'target_name': 'user_manager_dialog',
Moe 2016/06/03 21:51:50 Had to remove this target b/c adding the following
Dan Beam 2016/06/03 22:00:47 why? can you paste the error? it's better to fix
Moe 2016/06/06 16:29:20 I didn't know we modify the third party Polymer JS
+ 'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
+ },
+ {
'target_name': 'user_manager_pages',
'includes': ['../../../../third_party/closure_compiler/compile_js2.gypi'],
},
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/resources/md_user_manager/create_profile.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698