Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: chrome/browser/resources/md_user_manager/error_dialog.html

Issue 2024233003: MD User Manager: Refactors existing dialogs in User Manager into <user-manager-dialog> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md-user-manager-locked-test
Patch Set: Updates backdrop's opacity Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://md-user-manager/shared_styles.html"> 1 <link rel="import" href="chrome://md-user-manager/shared_styles.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://md-user-manager/user_manager_dialog.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 4
7 <!-- TODO(mahmadi): refactor this and import-supervised-user reusing
8 <paper-dialog> or <settings-dialog> -->
9 <dom-module id="error-dialog"> 5 <dom-module id="error-dialog">
10 <template> 6 <template>
11 <style include="shared-styles"> 7 <style include="shared-styles">
12 #backdrop {
13 align-items: center;
14 background: rgba(255, 255, 255, 0.6);
15 bottom: 0;
16 display: flex;
17 justify-content: center;
18 left: 0;
19 position: absolute;
20 right: 0;
21 top: 0;
22 }
23
24 #dialog { 8 #dialog {
25 background: white; 9 --user-manager-dialog-title-bar: {
26 border-radius: 2px; 10 border-bottom-width: 0;
27 box-shadow: 0 16px 24px 2px rgba(0, 0, 0, 0.14),
28 0 6px 30px 5px rgba(0, 0, 0, 0.12),
29 0 8px 10px -5px rgba(0, 0, 0, 0.4);
30 color: var(--primary-text-color);
31 width: 512px;
32 }
33
34 #title-bar {
35 padding: 6px;
36 }
37
38 #title-bar paper-icon-button {
39 --paper-icon-button: {
40 padding: 10px;
41 }; 11 };
42 } 12 }
43
44 #message { 13 #message {
45 padding: 10px 16px 62px;
46 white-space: pre-wrap; 14 white-space: pre-wrap;
47 word-wrap: break-word; 15 word-wrap: break-word;
16 margin-bottom: 52px;
48 } 17 }
49 </style> 18 </style>
50 <template is="dom-if" if="[[!popupHidden_]]"> 19 <user-manager-dialog id="dialog">
51 <div id="backdrop"> 20 <div class="body">
52 <div id="dialog"> 21 <div id="message">[[message_]]</div>
dpapad 2016/06/08 23:05:12 Is this 2nd div necessary? Can it be merged to the
Moe 2016/06/09 14:10:03 user-manager-dialog gives a certain padding to bod
53 <div id="title-bar" class="horizontal end-justified layout">
54 <paper-icon-button icon="cr:close" on-tap="onCloseTap_">
55 </paper-icon-button>
56 </div>
57 <div id="message">[[message_]]</div>
58 </div>
59 </div> 22 </div>
60 </template> 23 </user-manager-dialog>
61 </template> 24 </template>
62 <script src="chrome://md-user-manager/error_dialog.js"></script> 25 <script src="chrome://md-user-manager/error_dialog.js"></script>
dpapad 2016/06/08 23:05:12 Nit: Is this equivalent to the shorter <script sr
Moe 2016/06/09 14:10:03 Makes sense! I left a todo here to update all thes
63 </dom-module> 26 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698