Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 202423002: Fix SourceBuffer.timestampOffset setter behavior for invalid values. (Closed)

Created:
6 years, 9 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 9 months ago
Reviewers:
adamk, wolenetz
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com, sof
Visibility:
Public.

Description

Fix SourceBuffer.timestampOffset setter behavior for invalid values. This patch adds logic to SourceBuffer::setTimestampOffset() to reject invalid values. A LayoutTest to verify proper behavior for a variety of values was also added. BUG=353245 TEST=LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169773

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address CR comments #

Patch Set 3 : Add expectation file since it appears the trybots need it. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
A LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html View 1 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset-expected.txt View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 21 (0 generated)
acolwell GONE FROM CHROMIUM
Depends on https://codereview.chromium.org/198213008/
6 years, 9 months ago (2014-03-17 19:34:14 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-17 20:09:16 UTC) #2
wolenetz
Missing expectation file, too? https://codereview.chromium.org/202423002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html File LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html (right): https://codereview.chromium.org/202423002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html#newcode19 LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html:19: if (expected == "TypeMismatchError") { ...
6 years, 9 months ago (2014-03-17 20:11:38 UTC) #3
acolwell GONE FROM CHROMIUM
On 2014/03/17 20:11:38, wolenetz wrote: > Missing expectation file, too? Expectation files aren't technically necessary ...
6 years, 9 months ago (2014-03-17 20:27:47 UTC) #4
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/202423002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html File LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html (right): https://codereview.chromium.org/202423002/diff/1/LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html#newcode19 LayoutTests/http/tests/media/media-source/mediasource-timestamp-offset.html:19: if (expected == "TypeMismatchError") { On 2014/03/17 20:11:39, wolenetz ...
6 years, 9 months ago (2014-03-17 20:28:27 UTC) #5
wolenetz
lgtm
6 years, 9 months ago (2014-03-17 20:31:28 UTC) #6
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-18 18:06:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/202423002/20001
6 years, 9 months ago (2014-03-18 18:07:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 18:10:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 18:10:42 UTC) #10
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-18 19:59:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/202423002/20001
6 years, 9 months ago (2014-03-18 19:59:03 UTC) #12
acolwell GONE FROM CHROMIUM
The CQ bit was unchecked by acolwell@chromium.org
6 years, 9 months ago (2014-03-18 20:00:11 UTC) #13
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-18 20:10:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/202423002/40001
6 years, 9 months ago (2014-03-18 20:10:48 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 20:13:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-18 20:13:42 UTC) #17
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-21 20:02:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/202423002/40001
6 years, 9 months ago (2014-03-21 20:02:37 UTC) #19
commit-bot: I haz the power
Change committed as 169773
6 years, 9 months ago (2014-03-22 04:06:14 UTC) #20
sof
6 years, 9 months ago (2014-03-22 07:51:22 UTC) #21
Message was sent while issue was closed. 
https://codereview.chromium.org/202423002/diff/40001/Source/modules/mediasour...
File Source/modules/mediasource/SourceBuffer.cpp (right):

https://codereview.chromium.org/202423002/diff/40001/Source/modules/mediasour...
Source/modules/mediasource/SourceBuffer.cpp:180:
exceptionState.throwDOMException(TypeMismatchError,
ExceptionMessages::notAFiniteNumber(offset));
This isn't quite right per WebIDL, infinities and NaN should throw TypeError --

  http://heycam.github.io/webidl/#es-double (4.2.14.2)

The old DOM exception TYPE_MISMATCH_ERR (TypeMismatchError) is preferably
avoided these days.

Powered by Google App Engine
This is Rietveld 408576698