Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2024203002: declare that dart2js fails some 'yield*' tests (Closed)

Created:
4 years, 6 months ago by Harry Terkelsen
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

declare that dart2js fails some 'yield*' tests These tests assert that 'yield*' expressions in non-generator functions should be a compile-time error. But the spec does not have yield as a reserved word, so a statement like 'yield* e;' can be interpreted as an expression statement multiplying the variable 'yield' by e. This is how dart2js and the VM interpret yield outside of generator functions. See the discussion in issue #25495 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e9d41ebc23ee341a027c5c4bb1b6af65a5d43a61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/co19/co19-dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 6 months ago (2016-05-31 18:06:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 6 months ago (2016-05-31 18:09:18 UTC) #3
Harry Terkelsen
4 years, 6 months ago (2016-05-31 18:10:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e9d41ebc23ee341a027c5c4bb1b6af65a5d43a61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698