Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2024163004: [DevTools] Adjust device mode rulers when using small scale. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Adjust device mode rulers when using small scale. BUG=600341 Committed: https://crrev.com/ab28abe897abe63801b81862354a2ea68b58ea24 Cr-Commit-Position: refs/heads/master@{#397319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
dgozman
Take a look please.
4 years, 6 months ago (2016-06-01 01:51:17 UTC) #2
lushnikov
lgtm
4 years, 6 months ago (2016-06-01 21:19:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024163004/1
4 years, 6 months ago (2016-06-01 21:49:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/222981)
4 years, 6 months ago (2016-06-01 23:14:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024163004/1
4 years, 6 months ago (2016-06-01 23:18:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239330)
4 years, 6 months ago (2016-06-02 01:53:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024163004/1
4 years, 6 months ago (2016-06-02 02:22:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/239469)
4 years, 6 months ago (2016-06-02 03:07:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024163004/1
4 years, 6 months ago (2016-06-02 05:40:56 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:43:14 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:44:38 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab28abe897abe63801b81862354a2ea68b58ea24
Cr-Commit-Position: refs/heads/master@{#397319}

Powered by Google App Engine
This is Rietveld 408576698