Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2024153002:
Add RtpHeaderExtension to avoid client breakage (Closed)
DescriptionAdd RtpHeaderExtension to avoid client breakage
This fixes a client breakage by adding back the RtpHeaderExtension temporarily
so that it can be fixed in the client before being removed in webrtc.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.win:win_chromium_rel_ng
Committed: https://crrev.com/a1c548b9b96094bd1b66bf417b6fde78a5c48af4
Cr-Commit-Position: refs/heads/master@{#12977}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Addressed nits #
Messages
Total messages: 32 (15 generated)
Description was changed from ========== Add RtpHeaderExtension to avoid google3 breakage This fixes a google3 breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= ========== to ========== Add RtpHeaderExtension to avoid google3 breakage This fixes a google3 breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= ==========
isheriff@chromium.org changed reviewers: + ossu@webrtc.org
Can you please verify this ?
isheriff@chromium.org changed reviewers: + stefan@webrtc.org
Oskar confirms this fixes the google3 breakage. Stefan, can you PTAL ?
ossu@chromium.org changed reviewers: + ossu@chromium.org
lgtm - tested it against google3.
drive by https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... File webrtc/media/base/fakemediaengine.h (right): https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... webrtc/media/base/fakemediaengine.h:721: for (cricket::RtpHeaderExtension ext : extensions) { creating a copy intentionally?
Description was changed from ========== Add RtpHeaderExtension to avoid google3 breakage This fixes a google3 breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= ========== to ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= ==========
https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... File webrtc/media/base/fakemediaengine.h (right): https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... webrtc/media/base/fakemediaengine.h:721: for (cricket::RtpHeaderExtension ext : extensions) { On 2016/05/31 16:28:21, tommi-chrömium wrote: > creating a copy intentionally? fixed
On 2016/05/31 16:49:58, Irfan wrote: > https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... > File webrtc/media/base/fakemediaengine.h (right): > > https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... > webrtc/media/base/fakemediaengine.h:721: for (cricket::RtpHeaderExtension ext : > extensions) { > On 2016/05/31 16:28:21, tommi-chrömium wrote: > > creating a copy intentionally? > > fixed Thanks! I didn't add myself as a reviewer, but lgtm just in case you need it.
Description was changed from ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= ========== to ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.win:win_chromium_rel_ng ==========
On 2016/05/31 16:51:22, tommi-chrömium wrote: > On 2016/05/31 16:49:58, Irfan wrote: > > > https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... > > File webrtc/media/base/fakemediaengine.h (right): > > > > > https://codereview.chromium.org/2024153002/diff/1/webrtc/media/base/fakemedia... > > webrtc/media/base/fakemediaengine.h:721: for (cricket::RtpHeaderExtension ext > : > > extensions) { > > On 2016/05/31 16:28:21, tommi-chrömium wrote: > > > creating a copy intentionally? > > > > fixed > > Thanks! > I didn't add myself as a reviewer, but lgtm just in case you need it. and now from the webrtc account even... hmm... was the original cr request sent out via codereview.chromium.org? (and not webrtc.org)
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
lgtm
lgtm
The CQ bit was checked by isheriff@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ossu@chromium.org Link to the patchset: https://codereview.chromium.org/2024153002/#ps20001 (title: "Addressed nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024153002/20001
Yes, I tend to use codereview.chromium when I can since I can use this extension for better code reviews: https://chrome.google.com/webstore/detail/rietveld-usability-toolki/nmljjlfbn...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13767)
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024153002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by isheriff@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024153002/20001
Message was sent while issue was closed.
Description was changed from ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.win:win_chromium_rel_ng ========== to ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.win:win_chromium_rel_ng ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.win:win_chromium_rel_ng ========== to ========== Add RtpHeaderExtension to avoid client breakage This fixes a client breakage by adding back the RtpHeaderExtension temporarily so that it can be fixed in the client before being removed in webrtc. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.chromium.win:win_chromium_rel_ng Committed: https://crrev.com/a1c548b9b96094bd1b66bf417b6fde78a5c48af4 Cr-Commit-Position: refs/heads/master@{#12977} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a1c548b9b96094bd1b66bf417b6fde78a5c48af4 Cr-Commit-Position: refs/heads/master@{#12977} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
