xfa_fm2jscontext method clean - pt II

xfa_fm2jscontext method clean - pt II

Cleanup ::Max, ::Floor, ::Count, ::Ceil, ::Avg and ::Abs. Remove unneeded
strings from reservesForDecode (saves 4k when building pdfium_test).

Committed: https://pdfium.googlesource.com/pdfium/+/89ba6de4150875f8095ced93e62cf71d0ec52c36

[dsinclair, 2016-05-31 13:35:19]

Patchset #1 (id:1) has been deleted

[dsinclair, 2016-05-31 13:36:40]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-31 13:36:41]

PTAL.

[Tom Sepez, 2016-05-31 17:36:45]

https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:37: const XFA_FMHtmlHashedReserveCode
reservesForDecode[] = {
You are going to hate me :).

Can we make an HRC() macro (hash-reserved-code) that expands differently in
debug vs. non-debug, keep the string around in debug, and make a static
initialier only in debug that checks whether the strings hash out according to
what we claim?

https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:629: int32_t uCount = 0;
nit: iCount, as the U would imply unsigned.

[Tom Sepez, 2016-05-31 17:42:04]

On 2016/05/31 17:36:45, Tom Sepez wrote:
>
https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
> File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):
> 
>
https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
> xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:37: const XFA_FMHtmlHashedReserveCode
> reservesForDecode[] = {
> You are going to hate me :).
> 
> Can we make an HRC() macro (hash-reserved-code) that expands differently in
> debug vs. non-debug, keep the string around in debug, and make a static
> initialier only in debug that checks whether the strings hash out according to
> what we claim?
> 
Or do it as a follow-up.  LGTM with nit otherwise.  Let's get this landed, I'm
about to hammer on another part of this file and would like it stable.

[dsinclair, 2016-05-31 18:45:58]

https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:37: const XFA_FMHtmlHashedReserveCode
reservesForDecode[] = {
On 2016/05/31 17:36:44, Tom Sepez wrote:
> You are going to hate me :).
> 
> Can we make an HRC() macro (hash-reserved-code) that expands differently in
> debug vs. non-debug, keep the string around in debug, and make a static
> initialier only in debug that checks whether the strings hash out according to
> what we claim?
> 


Followup.

https://codereview.chromium.org/2024133002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:629: int32_t uCount = 0;
On 2016/05/31 17:36:44, Tom Sepez wrote:
> nit: iCount, as the U would imply unsigned.

Have I mentioned how much I'm growing to dislike hungarian notation? So much
churn ....

[dsinclair, 2016-05-31 18:56:24]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-31 18:56:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2024133002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-31 18:56:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024133002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024133002/40001

[commit-bot: I haz the power, 2016-05-31 19:11:25]

Description was changed from

==========
xfa_fm2jscontext method clean - pt II

Cleanup ::Max, ::Floor, ::Count, ::Ceil, ::Avg and ::Abs. Remove unneeded
strings from reservesForDecode (saves 4k when building pdfium_test).
==========

to

==========
xfa_fm2jscontext method clean - pt II

Cleanup ::Max, ::Floor, ::Count, ::Ceil, ::Avg and ::Abs. Remove unneeded
strings from reservesForDecode (saves 4k when building pdfium_test).

Committed:
https://pdfium.googlesource.com/pdfium/+/89ba6de4150875f8095ced93e62cf71d0ec5...
==========

[commit-bot: I haz the power, 2016-05-31 19:11:26]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/89ba6de4150875f8095ced93e62cf71d0ec5...