Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2024123002: Fix bytecode operand values (Closed)

Created:
4 years, 6 months ago by miran.karic
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bytecode operand values A few values were missing use of a macro causing test to fail on big endian machines. BUG= Committed: https://crrev.com/b8786b35fcbf4cec390cf22a0c5da42e690df77b Cr-Commit-Position: refs/heads/master@{#36645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/unittests/interpreter/bytecodes-unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
miran.karic
4 years, 6 months ago (2016-05-31 12:27:22 UTC) #2
rmcilroy
lgtm, thanks for the fix.
4 years, 6 months ago (2016-06-01 11:05:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024123002/1
4 years, 6 months ago (2016-06-01 12:36:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 13:03:49 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:05:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8786b35fcbf4cec390cf22a0c5da42e690df77b
Cr-Commit-Position: refs/heads/master@{#36645}

Powered by Google App Engine
This is Rietveld 408576698