src/hydrogen.cc - Issue 20241005: Fix IsDeletable() for HStringAdd, HStringCharCodeAt, HStringCharFromCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 20241005: Fix IsDeletable() for HStringAdd, HStringCharCodeAt, HStringCharFromCode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 0aae86129732f4b93ff35306dddcc38b05056e9a..03f7eb447690ee594a9e6a0c55a9104a1809a015 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -9078,7 +9078,6 @@ void HOptimizedGraphBuilder::GenerateRandomHeapNumber(CallRuntime* call) {

}

-// Fast support for StringAdd.

Michael Starzinger 2013/07/25 14:43:18 nit: Can we get the comment back?

titzer 2013/07/25 15:32:55 Well, I wanted that one for my code offsets, but I

void HOptimizedGraphBuilder::GenerateStringAdd(CallRuntime* call) {

ASSERT_EQ(2, call->arguments()->length());

CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));

« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | src/hydrogen-instructions.h » ('J')