Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 20241005: Fix IsDeletable() for HStringAdd, HStringCharCodeAt, HStringCharFromCode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix predicate for ToStringCanBeObserved() and private-ness of IsDeletable() Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/hydrogen-instructions.h ('K') | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3667 matching lines...) Expand 10 before | Expand all | Expand 10 after
3678 Representation HUnaryMathOperation::RepresentationFromInputs() { 3678 Representation HUnaryMathOperation::RepresentationFromInputs() {
3679 Representation rep = representation(); 3679 Representation rep = representation();
3680 // If any of the actual input representation is more general than what we 3680 // If any of the actual input representation is more general than what we
3681 // have so far but not Tagged, use that representation instead. 3681 // have so far but not Tagged, use that representation instead.
3682 Representation input_rep = value()->representation(); 3682 Representation input_rep = value()->representation();
3683 if (!input_rep.IsTagged()) rep = rep.generalize(input_rep); 3683 if (!input_rep.IsTagged()) rep = rep.generalize(input_rep);
3684 return rep; 3684 return rep;
3685 } 3685 }
3686 3686
3687 3687
3688 HType HStringCharFromCode::CalculateInferredType() {
3689 return HType::String();
3690 }
3691
3692
3693 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect, 3688 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
3694 HValue* dominator) { 3689 HValue* dominator) {
3695 ASSERT(side_effect == kChangesNewSpacePromotion); 3690 ASSERT(side_effect == kChangesNewSpacePromotion);
3696 if (!FLAG_use_allocation_folding) return; 3691 if (!FLAG_use_allocation_folding) return;
3697 3692
3698 // Try to fold allocations together with their dominating allocations. 3693 // Try to fold allocations together with their dominating allocations.
3699 if (!dominator->IsAllocate()) { 3694 if (!dominator->IsAllocate()) {
3700 if (FLAG_trace_allocation_folding) { 3695 if (FLAG_trace_allocation_folding) {
3701 PrintF("#%d (%s) cannot fold into #%d (%s)\n", 3696 PrintF("#%d (%s) cannot fold into #%d (%s)\n",
3702 id(), Mnemonic(), dominator->id(), dominator->Mnemonic()); 3697 id(), Mnemonic(), dominator->id(), dominator->Mnemonic());
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
4493 case kBackingStore: 4488 case kBackingStore:
4494 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString()); 4489 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString());
4495 stream->Add("[backing-store]"); 4490 stream->Add("[backing-store]");
4496 break; 4491 break;
4497 } 4492 }
4498 4493
4499 stream->Add("@%d", offset()); 4494 stream->Add("@%d", offset());
4500 } 4495 }
4501 4496
4502 } } // namespace v8::internal 4497 } } // namespace v8::internal
OLDNEW
« src/hydrogen-instructions.h ('K') | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698