Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Side by Side Diff: test/mjsunit/compiler/dead-string-add.js

Issue 20241005: Fix IsDeletable() for HStringAdd, HStringCharCodeAt, HStringCharFromCode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add test cases and simplify conditions for removal of checks. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 function dead1(a, b) { 28 function dead1(a, b) {
29 a + b; // dead 29 var x = "a" + "b";
30 return a; 30 return a; // x, "a", and "b" are dead code
31 } 31 }
32 32
33 function dead2(a, b) { 33 function dead2(a, b) {
34 a | 0; // dead 34 var x = a + "0";
35 b | 0; // dead 35 var y = b + "0";
36 return a; // x and y are both dead 36 return a; // x and y are both dead
37 } 37 }
38 38
39 function dead3(a, b) { 39 function dead3(a, b) {
40 a == 2 ? a : b; // dead 40 a = a ? "1" : "0";
41 return a; 41 b = b ? "1" : "0";
42 } 42 var x = a + "0";
43 43 var y = b + "0";
44 function dead4(a) { 44 return a; // x and y are both dead
45 var z = 3;
46 for (i = 0; i < 3; i++) {
47 z + 3; // dead
48 }
49 return a;
50 }
51
52 function dead5(a) {
53 var z = 3;
54 for (i = 0; i < 3; i++) {
55 z + 3; // dead
56 z++;
57 }
58 var w = z + a;
59 return a; // z is dead
60 } 45 }
61 46
62 assertTrue(dead1(33, 32) == 33); 47 assertTrue(dead1(33, 32) == 33);
63 assertTrue(dead2(33, 32) == 33); 48 assertTrue(dead2(33, 32) == 33);
64 assertTrue(dead3(33, 32) == 33); 49 assertTrue(dead3(33, 32) == "1");
65 assertTrue(dead4(33) == 33);
66 assertTrue(dead5(33) == 33);
67 50
68 assertTrue(dead1(34, 7) == 34); 51 assertTrue(dead1(31, 30) == 31);
69 assertTrue(dead2(34, 7) == 34); 52 assertTrue(dead2(31, 30) == 31);
70 assertTrue(dead3(34, 7) == 34); 53 assertTrue(dead3(31, 32) == "1");
71 assertTrue(dead4(34) == 34);
72 assertTrue(dead5(34) == 34);
73 54
74 assertTrue(dead1(3.4, 0.1) == 3.4); 55 assertTrue(dead1(0, 30) == 0);
75 assertTrue(dead2(3.4, 0.1) == 3.4); 56 assertTrue(dead2(0, 30) == 0);
76 assertTrue(dead3(3.4, 0.1) == 3.4); 57 assertTrue(dead3(0, 32) == "0");
77 assertTrue(dead4(3.4) == 3.4); 58
78 assertTrue(dead5(3.4) == 3.4); 59 assertTrue(dead1(true, 0) == true);
60 assertTrue(dead2(true, 0) == true);
61 assertTrue(dead3(true, 0) == "1");
62
63 assertTrue(dead1("true", 0) == "true");
64 assertTrue(dead2("true", 0) == "true");
65 assertTrue(dead3("true", 0) == "1");
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698