Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 20241005: Fix IsDeletable() for HStringAdd, HStringCharCodeAt, HStringCharFromCode. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add test cases and simplify conditions for removal of checks. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3700 matching lines...) Expand 10 before | Expand all | Expand 10 after
3711 Representation HUnaryMathOperation::RepresentationFromInputs() { 3711 Representation HUnaryMathOperation::RepresentationFromInputs() {
3712 Representation rep = representation(); 3712 Representation rep = representation();
3713 // If any of the actual input representation is more general than what we 3713 // If any of the actual input representation is more general than what we
3714 // have so far but not Tagged, use that representation instead. 3714 // have so far but not Tagged, use that representation instead.
3715 Representation input_rep = value()->representation(); 3715 Representation input_rep = value()->representation();
3716 if (!input_rep.IsTagged()) rep = rep.generalize(input_rep); 3716 if (!input_rep.IsTagged()) rep = rep.generalize(input_rep);
3717 return rep; 3717 return rep;
3718 } 3718 }
3719 3719
3720 3720
3721 HType HStringCharFromCode::CalculateInferredType() {
3722 return HType::String();
3723 }
3724
3725
3726 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect, 3721 void HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
3727 HValue* dominator) { 3722 HValue* dominator) {
3728 ASSERT(side_effect == kChangesNewSpacePromotion); 3723 ASSERT(side_effect == kChangesNewSpacePromotion);
3729 if (!FLAG_use_allocation_folding) return; 3724 if (!FLAG_use_allocation_folding) return;
3730 3725
3731 // Try to fold allocations together with their dominating allocations. 3726 // Try to fold allocations together with their dominating allocations.
3732 if (!dominator->IsAllocate()) { 3727 if (!dominator->IsAllocate()) {
3733 if (FLAG_trace_allocation_folding) { 3728 if (FLAG_trace_allocation_folding) {
3734 PrintF("#%d (%s) cannot fold into #%d (%s)\n", 3729 PrintF("#%d (%s) cannot fold into #%d (%s)\n",
3735 id(), Mnemonic(), dominator->id(), dominator->Mnemonic()); 3730 id(), Mnemonic(), dominator->id(), dominator->Mnemonic());
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
4535 case kBackingStore: 4530 case kBackingStore:
4536 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString()); 4531 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString());
4537 stream->Add("[backing-store]"); 4532 stream->Add("[backing-store]");
4538 break; 4533 break;
4539 } 4534 }
4540 4535
4541 stream->Add("@%d", offset()); 4536 stream->Add("@%d", offset());
4542 } 4537 }
4543 4538
4544 } } // namespace v8::internal 4539 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698