Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.cc

Issue 2024093002: [Smart Lock] Adds UMA Metrics for actions on Account Chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/account_chooser_dialog_android.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc
index f33ed44f2c5c104c8cfaf8066367675aa088bd40..035cfa13800b09e80bf6729e9eff7805e5b2c437 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc
@@ -20,6 +20,7 @@
#include "components/browser_sync/browser/profile_sync_service.h"
#include "components/password_manager/core/browser/password_bubble_experiment.h"
#include "components/password_manager/core/browser/password_manager_constants.h"
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/password_manager/core/browser/password_ui_utils.h"
#include "components/password_manager/core/common/credential_manager_types.h"
#include "jni/AccountChooserDialog_jni.h"
@@ -223,16 +224,27 @@ void AccountChooserDialogAndroid::ChooseCredential(
size_t index,
password_manager::CredentialType type) {
using namespace password_manager;
+ password_manager::metrics_util::AccountChooserUserAction action;
if (type == CredentialType::CREDENTIAL_TYPE_EMPTY) {
passwords_data_.ChooseCredential(nullptr);
- return;
+ action = password_manager::metrics_util::ACCOUNT_CHOOSER_DISMISSED;
+ } else {
+ action = password_manager::metrics_util::ACCOUNT_CHOOSER_CREDENTIAL_CHOSEN;
+ const auto& credentials_forms =
+ (type == CredentialType::CREDENTIAL_TYPE_PASSWORD)
+ ? local_credentials_forms()
+ : federated_credentials_forms();
+ if (index < credentials_forms.size()) {
+ passwords_data_.ChooseCredential(credentials_forms[index]);
+ }
}
- const auto& credentials_forms =
- (type == CredentialType::CREDENTIAL_TYPE_PASSWORD)
- ? local_credentials_forms()
- : federated_credentials_forms();
- if (index < credentials_forms.size()) {
- passwords_data_.ChooseCredential(credentials_forms[index]);
+
+ if (local_credentials_forms().size() == 1) {
+ password_manager::metrics_util::LogAccountChooserUserActionOneAccount(
+ action);
+ } else {
+ password_manager::metrics_util::LogAccountChooserUserActionManyAccounts(
+ action);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698