Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h |
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h |
index b6d98ab1cee403410831c3e29a54a7eb8af56ff2..a89ede5eb0d45cb43426b45a928f2aae76675a17 100644 |
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h |
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h |
@@ -34,15 +34,26 @@ public: |
bool checkConstructorIntrinsics() override; |
bool checkConstructorNotRegistered() override; |
bool checkPrototype() override; |
+ bool cacheProperties() override; |
CustomElementDefinition* build(const CustomElementDescriptor&) override; |
private: |
+ friend class ScriptCustomElementDefinition; |
dominicc (has gone to gerrit)
2016/06/02 00:31:27
I don't really like the ScriptCustomElementDefinit
yosin_UTC9
2016/06/02 01:33:38
When const-ish isn't important in |ScriptCusomElem
kojii
2016/06/02 03:18:08
Reverted.
|
+ |
RefPtr<ScriptState> m_scriptState; |
Member<CustomElementsRegistry> m_registry; |
v8::Local<v8::Value> m_constructorValue; |
v8::Local<v8::Object> m_constructor; |
v8::Local<v8::Object> m_prototype; |
+ v8::Local<v8::Object> m_connectedCallback; |
+ v8::Local<v8::Object> m_disconnectedCallback; |
+ v8::Local<v8::Object> m_attributeChangedCallback; |
+ Vector<AtomicString> m_observedAttributes; |
dominicc (has gone to gerrit)
2016/06/02 00:31:27
Any reason not to just make this a HashSet and mov
kojii
2016/06/02 03:18:08
Done. Not really, had a micro-optimization in mind
|
ExceptionState& m_exceptionState; |
+ |
+ bool getValue(const v8::Local<v8::Object>&, const char*, |
yosin_UTC9
2016/06/02 01:33:38
Term "get" is so usual, we should use another name
|
+ v8::Local<v8::Value>&) const; |
+ bool getCallable(const char*, v8::Local<v8::Object>&) const; |
yosin_UTC9
2016/06/02 01:33:38
In Blink, getter doesn't have "get", but in other
kojii
2016/06/02 03:18:08
Done, thought "get" is chromium style but I don't
|
}; |
} // namespace blink |