Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make ScriptCustomElementDefinitionBuilder friend to ScriptCustomElementDefinition Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
index 571d2e5603748276b4e41fc5671b64c38268508b..637712677415893023409fad619a369ebd74ee5f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
@@ -9,12 +9,16 @@
#include "core/CoreExport.h"
#include "core/dom/custom/CustomElementDefinition.h"
#include "v8.h"
+#include "wtf/HashSet.h"
#include "wtf/Noncopyable.h"
+#include "wtf/text/AtomicString.h"
+#include "wtf/text/AtomicStringHash.h"
namespace blink {
class CustomElementDescriptor;
class CustomElementsRegistry;
+class ScriptCustomElementDefinitionBuilder;
class ScriptState;
class CORE_EXPORT ScriptCustomElementDefinition final :
@@ -27,11 +31,8 @@ public:
const v8::Local<v8::Value>& constructor);
static ScriptCustomElementDefinition* create(
- ScriptState*,
- CustomElementsRegistry*,
const CustomElementDescriptor&,
- const v8::Local<v8::Object>& constructor,
- const v8::Local<v8::Object>& prototype);
+ const ScriptCustomElementDefinitionBuilder&);
virtual ~ScriptCustomElementDefinition() = default;
@@ -40,14 +41,16 @@ public:
private:
ScriptCustomElementDefinition(
- ScriptState*,
const CustomElementDescriptor&,
- const v8::Local<v8::Object>& constructor,
- const v8::Local<v8::Object>& prototype);
+ const ScriptCustomElementDefinitionBuilder&);
RefPtr<ScriptState> m_scriptState;
ScopedPersistent<v8::Object> m_constructor;
ScopedPersistent<v8::Object> m_prototype;
+ ScopedPersistent<v8::Object> m_connectedCallback;
+ ScopedPersistent<v8::Object> m_disconnectedCallback;
+ ScopedPersistent<v8::Object> m_attributeChangedCallback;
+ HashSet<AtomicString> m_observedAttributes;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698