Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix when no callbacks, cleanup, and reset-result Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
index b6d98ab1cee403410831c3e29a54a7eb8af56ff2..9167ff8db38bcd78fcb02275c22b47df00a693b5 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
@@ -34,6 +34,7 @@ public:
bool checkConstructorIntrinsics() override;
bool checkConstructorNotRegistered() override;
bool checkPrototype() override;
+ bool cacheProperties() override;
CustomElementDefinition* build(const CustomElementDescriptor&) override;
private:
@@ -42,7 +43,15 @@ private:
v8::Local<v8::Value> m_constructorValue;
v8::Local<v8::Object> m_constructor;
v8::Local<v8::Object> m_prototype;
+ v8::Local<v8::Object> m_connectedCallback;
+ v8::Local<v8::Object> m_disconnectedCallback;
+ v8::Local<v8::Object> m_attributeChangedCallback;
+ Vector<AtomicString> m_observedAttributes;
ExceptionState& m_exceptionState;
+
+ bool getValue(const v8::Local<v8::Object>&, const char*,
+ v8::Local<v8::Value>&) const;
+ bool getCallable(const char*, v8::Local<v8::Object>&) const;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698