third_party/WebKit/Source/bindings/core/v8/V8Binding.h - Issue 2024073002: Add callbacks to ScriptCustomElementDefinition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tryCatch Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

index 193079c35569586ef22902dd8fbaa4b3ba997b78..13a9fdc71cd3bdd388ad33aaa8cc80c48c256297 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h

@@ -775,6 +775,17 @@ struct NativeValueTraits<String> {

};

template<>

+struct NativeValueTraits<AtomicString> {

+ static inline AtomicString nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)

+ {

+ V8StringResource<> stringValue(value);

+ if (!stringValue.prepare(exceptionState))

+ return AtomicString();

+ return stringValue;

+ }

+};

+template<>

struct NativeValueTraits<int> {

static inline int nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)

{