Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tryCatch Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
index e8fa2d36f4d792507e3277cb3589bced1e1cc743..1589b871786399a756e0a5107305e87a95a92ca0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.h
@@ -10,8 +10,11 @@
#include "platform/heap/Handle.h"
#include "v8.h"
#include "wtf/Allocator.h"
+#include "wtf/HashSet.h"
#include "wtf/Noncopyable.h"
#include "wtf/RefPtr.h"
+#include "wtf/text/AtomicString.h"
+#include "wtf/text/AtomicStringHash.h"
namespace blink {
@@ -35,6 +38,7 @@ public:
bool checkConstructorIntrinsics() override;
bool checkConstructorNotRegistered() override;
bool checkPrototype() override;
+ bool rememberOriginalProperties() override;
CustomElementDefinition* build(const CustomElementDescriptor&) override;
private:
@@ -46,7 +50,15 @@ private:
v8::Local<v8::Value> m_constructorValue;
v8::Local<v8::Object> m_constructor;
v8::Local<v8::Object> m_prototype;
+ v8::Local<v8::Object> m_connectedCallback;
+ v8::Local<v8::Object> m_disconnectedCallback;
+ v8::Local<v8::Object> m_attributeChangedCallback;
+ HashSet<AtomicString> m_observedAttributes;
ExceptionState& m_exceptionState;
+
+ bool valueForName(const v8::Local<v8::Object>&, const String&, v8::Local<v8::Value>&) const;
+ bool callableForName(const String&, v8::Local<v8::Object>&) const;
+ bool retrieveObservedAttributes();
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698