third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp - Issue 2024073002: Add callbacks to ScriptCustomElementDefinition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haraken review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

index 4aad4add12afb806e1341e4d20e2ac30b0e6acf7..5e3006715930a5db4c01f66ca9dc08175ed23583 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistryTest.cpp

@@ -286,6 +286,7 @@ public:

bool checkConstructorIntrinsics() override { return true; }

bool checkConstructorNotRegistered() override { return true; }

bool checkPrototype() override { return true; }

+ bool retrieveProperties() override { return true; }

CustomElementDefinition* build(

const CustomElementDescriptor& descriptor) {

return new LogUpgradeDefinition(descriptor);