Add callbacks to ScriptCustomElementDefinition

third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/custom/CustomElementsRegistry.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptCustomElementDefinitionBuilder.h"
 #include "core/dom/Document.h"
 #include "core/dom/ElementRegistrationOptions.h"
@@ skipping 66 matching lines @@
             "this name has already been used with this registry");
         return;
     }
 
     if (!builder.checkConstructorNotRegistered())
         return;
 
     // TODO(dominicc): Implement steps:
     // 5: localName
     // 6-7: extends processing
-    // 8-9: observed attributes caching
+
+    // 8-9: observed attributes caching is done below, together with callbacks.

[dominicc (has gone to gerrit), 2016/06/02 00:31:27]

Do these tests in order. Authors can observe this order.

You can suggest domenic change the spec, and put a TODO that points to the spec
issue.

 
     // TODO(dominicc): Add a test where the prototype getter destroys
     // the context.
 
     if (!builder.checkPrototype())
         return;
 
-    // TODO(dominicc): Implement steps:
+    // 8-9: observed attributes caching

[dominicc (has gone to gerrit), 2016/06/02 00:31:27]

I think we can remove this comment; it might be useful to add a comment to
cacheProperties indicating which steps it refers to.

     // 12-13: connected callback
     // 14-15: disconnected callback
     // 16-17: attribute changed callback
 
+    if (!builder.cacheProperties())
+        return;
+
     // TODO(dominicc): Add a test where retrieving the prototype
     // recursively calls define with the same name.
 
     CustomElementDescriptor descriptor(name, name);
     CustomElementDefinition* definition = builder.build(descriptor);
     CHECK(!exceptionState.hadException());
     CHECK(definition->descriptor() == descriptor);
     DefinitionMap::AddResult result =
         m_definitions.add(descriptor.name(), definition);
     CHECK(result.isNewEntry);
 
     // TODO(dominicc): Implement steps:
     // 20: when-defined promise processing
 }
 
 bool CustomElementsRegistry::v0NameIsDefined(const AtomicString& name) const
 {
     if (!m_v0)
         return false;
     return m_v0->nameIsDefined(name);
 }
 
 CustomElementDefinition* CustomElementsRegistry::definitionForName(
     const AtomicString& name) const
 {
     return m_definitions.get(name);
 }
 
 } // namespace blink