Add callbacks to ScriptCustomElementDefinition

third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptCustomElementDefinition_h
 #define ScriptCustomElementDefinition_h
 
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "core/CoreExport.h"
 #include "core/dom/custom/CustomElementDefinition.h"
 #include "v8.h"
+#include "wtf/HashSet.h"
 #include "wtf/Noncopyable.h"
+#include "wtf/text/AtomicString.h"
+#include "wtf/text/AtomicStringHash.h"
 
 namespace blink {
 
 class CustomElementDescriptor;
 class CustomElementsRegistry;
 class ScriptState;
 
 class CORE_EXPORT ScriptCustomElementDefinition final :
     public CustomElementDefinition {
     WTF_MAKE_NONCOPYABLE(ScriptCustomElementDefinition);
 public:
     static ScriptCustomElementDefinition* forConstructor(
         ScriptState*,
         CustomElementsRegistry*,
         const v8::Local<v8::Value>& constructor);
 
     static ScriptCustomElementDefinition* create(
         ScriptState*,
         CustomElementsRegistry*,
         const CustomElementDescriptor&,
         const v8::Local<v8::Object>& constructor,

[yosin_UTC9, 2016/06/01 06:33:33]

Can we have struct ScriptCustomElementDefinitionInit or another name to as pass
v8::Local by name?
It is error prone to have many parameters with same type.

struct Init {
  v8::Local<v8::Object> constructor;
  v8::Local<v8::Object> prototype;
  ...
};


Init init;
init.constructor = ...
init.prototype = ...

[kojii, 2016/06/01 07:19:27]

I think it's too much complex, when we have ScriptCustomElementDefinition and
ScriptCustomElementDefinitionBuilder having almost the same members, and add yet
another, 3rd almost similar struct.

[kojii, 2016/06/01 13:49:10]

I made ScriptCustomElementDefinitionBuilder friend to
ScriptCustomElementDefinition is PS5. Hope this resolves your concern.

-        const v8::Local<v8::Object>& prototype);
+        const v8::Local<v8::Object>& prototype,
+        const v8::Local<v8::Object>& connectedCallback,
+        const v8::Local<v8::Object>& disconnectedCallback,
+        const v8::Local<v8::Object>& attributeChangedCallback,
+        const Vector<AtomicString>& observedAttributes);
 
     virtual ~ScriptCustomElementDefinition() = default;
 
     v8::Local<v8::Object> constructor(ScriptState*) const;
     v8::Local<v8::Object> prototype(ScriptState*) const;
 
 private:
     ScriptCustomElementDefinition(
         ScriptState*,
         const CustomElementDescriptor&,
         const v8::Local<v8::Object>& constructor,
-        const v8::Local<v8::Object>& prototype);
+        const v8::Local<v8::Object>& prototype,
+        const v8::Local<v8::Object>& connectedCallback,

[yosin_UTC9, 2016/06/01 06:33:33]

FYI, since v8::Local<T> is just T*, pass by value may be faster.
See comment in "base/strings/string_piece.h"

[kojii, 2016/06/01 07:19:27]

I can do that, but Set and many v8 functions receives Local, so I'll need to
re-create them. Isn't it faster to pass reference than re-creating Locals?
Which comment? I looked at the file but don't understand which comment in the
file you're referring to.

+        const v8::Local<v8::Object>& disconnectedCallback,
+        const v8::Local<v8::Object>& attributeChangedCallback,
+        const Vector<AtomicString>& observedAttributes);
 
     ScopedPersistent<v8::Object> m_constructor;
     ScopedPersistent<v8::Object> m_prototype;
+    ScopedPersistent<v8::Object> m_connectedCallback;
+    ScopedPersistent<v8::Object> m_disconnectedCallback;
+    ScopedPersistent<v8::Object> m_attributeChangedCallback;
+    HashSet<AtomicString> m_observedAttributes;
 };
 
 } // namespace blink
 
 #endif // ScriptCustomElementDefinition_h