Add callbacks to ScriptCustomElementDefinition

third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/custom/CustomElementsRegistry.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptCustomElementDefinitionBuilder.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
@@ skipping 105 matching lines @@
             "this name has already been used with this registry");
         return;
     }
 
     if (!builder.checkConstructorNotRegistered())
         return;
 
     // TODO(dominicc): Implement steps:
     // 5: localName
     // 6-7: extends processing
-    // 8-9: observed attributes caching
+
+    // 8-9: observed attributes caching is done below, together with callbacks.
+    // TODO(kojii): https://github.com/whatwg/html/issues/1373 for the ordering.
+    // When it's resolved, revisit if this code needs changes.
 
     // TODO(dominicc): Add a test where the prototype getter destroys
     // the context.
 
     if (!builder.checkPrototype())
         return;
 
-    // TODO(dominicc): Implement steps:
+    // 8-9: observed attributes caching
     // 12-13: connected callback
     // 14-15: disconnected callback
     // 16-17: attribute changed callback
 
+    if (!builder.retrieveProperties())
+        return;
+
     // TODO(dominicc): Add a test where retrieving the prototype
     // recursively calls define with the same name.
 
     CustomElementDescriptor descriptor(name, name);
     CustomElementDefinition* definition = builder.build(descriptor);
     CHECK(!exceptionState.hadException());
     CHECK(definition->descriptor() == descriptor);
     DefinitionMap::AddResult result =
         m_definitions.add(descriptor.name(), definition);
     CHECK(result.isNewEntry);
@@ skipping 74 matching lines @@
         if (!element || !desc.matches(*element))
             continue;
         sorter.add(element);
     }
 
     m_upgradeCandidates->remove(it);
     sorter.sorted(elements, m_document.get());
 }
 
 } // namespace blink