Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2024063002: Reland "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Track based on JSArrayBuffer addresses on pages instead of the attached backing store. Details of tracking: - Scavenge: New space pages are processes in bulk on the main thread - MC: Unswept pages are processed in bulk in parallel. All other pages are processed by the sweeper concurrently. BUG=chromium:611688 LOG=N TEST=cctest/test-array-buffer-tracker/* CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Committed: https://crrev.com/089da007bb990b5b29aab257aa836fdd3f3b8ce0 Cr-Commit-Position: refs/heads/master@{#36608}

Patch Set 1 : base #

Patch Set 2 : bugfix and test added #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -183 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 2 chunks +92 lines, -40 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 1 1 chunk +145 lines, -90 lines 0 comments Download
A src/heap/array-buffer-tracker-inl.h View 1 1 chunk +93 lines, -0 lines 2 comments Download
M src/heap/heap.h View 4 chunks +12 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +3 lines, -11 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 9 chunks +16 lines, -18 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +32 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 3 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A test/cctest/heap/test-array-buffer-tracker.cc View 1 1 chunk +267 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024063002/20001
4 years, 6 months ago (2016-05-31 07:55:59 UTC) #7
Hannes Payer (out of office)
https://codereview.chromium.org/2024063002/diff/20001/src/heap/array-buffer-tracker-inl.h File src/heap/array-buffer-tracker-inl.h (right): https://codereview.chromium.org/2024063002/diff/20001/src/heap/array-buffer-tracker-inl.h#newcode24 src/heap/array-buffer-tracker-inl.h:24: if (Marking::IsBlack(Marking::MarkBitFrom(new_buffer))) { Is Black or Grey?
4 years, 6 months ago (2016-05-31 08:03:51 UTC) #8
Hannes Payer (out of office)
LGTM
4 years, 6 months ago (2016-05-31 08:15:41 UTC) #9
Michael Lippautz
https://codereview.chromium.org/2024063002/diff/20001/src/heap/array-buffer-tracker-inl.h File src/heap/array-buffer-tracker-inl.h (right): https://codereview.chromium.org/2024063002/diff/20001/src/heap/array-buffer-tracker-inl.h#newcode24 src/heap/array-buffer-tracker-inl.h:24: if (Marking::IsBlack(Marking::MarkBitFrom(new_buffer))) { On 2016/05/31 08:03:50, Hannes Payer wrote: ...
4 years, 6 months ago (2016-05-31 08:17:06 UTC) #11
Michael Lippautz
https://codereview.chromium.org/2024063002/diff/20001/src/heap/array-buffer-tracker-inl.h File src/heap/array-buffer-tracker-inl.h (right): https://codereview.chromium.org/2024063002/diff/20001/src/heap/array-buffer-tracker-inl.h#newcode24 src/heap/array-buffer-tracker-inl.h:24: if (Marking::IsBlack(Marking::MarkBitFrom(new_buffer))) { On 2016/05/31 08:03:50, Hannes Payer wrote: ...
4 years, 6 months ago (2016-05-31 08:17:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024063002/20001
4 years, 6 months ago (2016-05-31 09:14:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 09:16:34 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/089da007bb990b5b29aab257aa836fdd3f3b8ce0 Cr-Commit-Position: refs/heads/master@{#36608}
4 years, 6 months ago (2016-05-31 09:17:06 UTC) #18
Michael Lippautz
4 years, 6 months ago (2016-05-31 09:30:50 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2028503003/ by mlippautz@chromium.org.

The reason for reverting is: Breaking
 
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds....

Powered by Google App Engine
This is Rietveld 408576698