Make ui::TextInputClient::IsEditCommandEnabled const.

Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
Committed: https://crrev.com/a0206b74c4e850c6aa266cb70a1504233a1e17c6
Cr-Commit-Position: refs/heads/master@{#399646}

[karandeepb, 2016-06-06 02:39:33]

Description was changed from

==========
Refactor1: Make IsEditCommandEnabled const.
==========

to

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

BUG=None
==========

[tapted, 2016-06-06 07:17:21]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2016-06-06 07:17:22]

You should keep BUG=586985 Also the CL description needs a sentence about why we
want/need to do this. (e.g. do other const methods want to call this?)

https://codereview.chromium.org/2024033006/diff/1/blimp/engine/feature/engine...
File blimp/engine/feature/engine_render_widget_feature_unittest.cc (right):

https://codereview.chromium.org/2024033006/diff/1/blimp/engine/feature/engine...
blimp/engine/feature/engine_render_widget_feature_unittest.cc:107: class
MockTextInputClient : public ui::TextInputClient {
Can this inherit from DummyTextInputClient instead?

[karandeepb, 2016-06-06 11:31:35]

Description was changed from

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

BUG=None
==========

to

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
==========

[karandeepb, 2016-06-06 11:32:18]

Description was changed from

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
==========

to

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
==========

[karandeepb, 2016-06-08 03:01:55]

PTAL Thanks.

https://codereview.chromium.org/2024033006/diff/1/blimp/engine/feature/engine...
File blimp/engine/feature/engine_render_widget_feature_unittest.cc (right):

https://codereview.chromium.org/2024033006/diff/1/blimp/engine/feature/engine...
blimp/engine/feature/engine_render_widget_feature_unittest.cc:107: class
MockTextInputClient : public ui::TextInputClient {
On 2016/06/06 07:17:21, tapted wrote:
> Can this inherit from DummyTextInputClient instead?

Will do this in a separate CL - https://codereview.chromium.org/2044593004/

[karandeepb, 2016-06-09 00:52:16]

karandeepb@chromium.org changed reviewers:
+ jochen@chromium.org, sky@chromium.org

[karandeepb, 2016-06-09 00:52:17]

+sky@ for ui/ review 
+jochen@ for content/ and components/ review.

[sky, 2016-06-09 17:21:56]

LGTM

[karandeepb, 2016-06-10 05:42:54]

ping jochen@. Thanks.

[jochen (gone - plz use gerrit), 2016-06-13 15:25:10]

lgtm

[karandeepb, 2016-06-14 02:17:01]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-06-14 02:17:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024033006/20001

[commit-bot: I haz the power, 2016-06-14 02:55:28]

Description was changed from

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
==========

to

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
==========

[commit-bot: I haz the power, 2016-06-14 02:55:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-14 02:55:38]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 03:40:26]

Description was changed from

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985
==========

to

==========
Make ui::TextInputClient::IsEditCommandEnabled const.

This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is
required as it will need to be called by other const methods in subsequent CLs
for crbug.com/586985.

BUG=586985

Committed: https://crrev.com/a0206b74c4e850c6aa266cb70a1504233a1e17c6
Cr-Commit-Position: refs/heads/master@{#399646}
==========

[commit-bot: I haz the power, 2016-06-14 03:40:28]

Patchset 2 (id:??) landed as
https://crrev.com/a0206b74c4e850c6aa266cb70a1504233a1e17c6
Cr-Commit-Position: refs/heads/master@{#399646}