Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2024033006: Make ui::TextInputClient::IsEditCommandEnabled const. (Closed)

Created:
4 years, 6 months ago by karandeepb
Modified:
4 years, 6 months ago
CC:
anandc+watch-blimp_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, jam, jbauman+watch_chromium.org, jessicag+watch-blimp_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, lhchavez+watch_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nona+watch_chromium.org, nyquist+watch-blimp_chromium.org, piman+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, James Su, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ui::TextInputClient::IsEditCommandEnabled const. This CL makes ui::TextInputClient::IsEditCommandEnabled a const method. This is required as it will need to be called by other const methods in subsequent CLs for crbug.com/586985. BUG=586985 Committed: https://crrev.com/a0206b74c4e850c6aa266cb70a1504233a1e17c6 Cr-Commit-Position: refs/heads/master@{#399646}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Messages

Total messages: 18 (8 generated)
tapted
You should keep BUG=586985 Also the CL description needs a sentence about why we want/need ...
4 years, 6 months ago (2016-06-06 07:17:22 UTC) #3
karandeepb
PTAL Thanks. https://codereview.chromium.org/2024033006/diff/1/blimp/engine/feature/engine_render_widget_feature_unittest.cc File blimp/engine/feature/engine_render_widget_feature_unittest.cc (right): https://codereview.chromium.org/2024033006/diff/1/blimp/engine/feature/engine_render_widget_feature_unittest.cc#newcode107 blimp/engine/feature/engine_render_widget_feature_unittest.cc:107: class MockTextInputClient : public ui::TextInputClient { On ...
4 years, 6 months ago (2016-06-08 03:01:55 UTC) #6
karandeepb
+sky@ for ui/ review +jochen@ for content/ and components/ review.
4 years, 6 months ago (2016-06-09 00:52:17 UTC) #8
sky
LGTM
4 years, 6 months ago (2016-06-09 17:21:56 UTC) #9
karandeepb
ping jochen@. Thanks.
4 years, 6 months ago (2016-06-10 05:42:54 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-13 15:25:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024033006/20001
4 years, 6 months ago (2016-06-14 02:17:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 02:55:30 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 02:55:38 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 03:40:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0206b74c4e850c6aa266cb70a1504233a1e17c6
Cr-Commit-Position: refs/heads/master@{#399646}

Powered by Google App Engine
This is Rietveld 408576698