Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2024033005: [crankshaft] HCall and HCallWithDescriptor should not override CalculateInferredType. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] HCall and HCallWithDescriptor should not override CalculateInferredType. We may set a proper HType on HCall or HCallWithDescriptor nodes, for example for the InstanceOfStub, where we know that the result is a boolean. So HCall and HCallWithDescriptor shall not ignore the type, but pass through whatever we set (defaulting to Tagged). R=jarin@chromium.org Committed: https://crrev.com/a6f6d8ad2e0945f0afea80e49494f5d495083ae7 Cr-Commit-Position: refs/heads/master@{#36630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-01 04:52:57 UTC) #1
Benedikt Meurer
Hey Jaro, Easy optimization for Crankshaft. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-01 05:18:29 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-01 06:38:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024033005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024033005/1
4 years, 6 months ago (2016-06-01 06:39:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 06:41:42 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 06:50:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6f6d8ad2e0945f0afea80e49494f5d495083ae7
Cr-Commit-Position: refs/heads/master@{#36630}

Powered by Google App Engine
This is Rietveld 408576698