Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 202403002: Land recent SPDY changes (Closed)

Created:
6 years, 9 months ago by Johnny
Modified:
6 years, 8 months ago
Reviewers:
cmp, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Add settings IDs to SpdyConstants. Refactor only, no behavioral change. This lands server change 63167890 by hkhalil. https://codereview.chromium.org/202383002/ Syntactic-only changes to use protocol_version() over spdy_version_ in SpdyFramer. Also use the lowest possible enumeration value when doing comparisons, which makes deprecating older versions easier. This lands server change 63165647 by hkhalil. https://codereview.chromium.org/202113002/ Add some break statements in spdy_protocol for clarity. This lands server change 63158241 by hkhalil. https://codereview.chromium.org/198213007/ Minor logging change for catching development errors during testing. This lands server change 63102059 by hkhalil. https://codereview.chromium.org/201943003/ Introduce new SpdyConstants class Used for translating between code constants and on-the-wire representations (which differ from version to version). Currently only handles SpdyFrameType constants. This lands server change 62928184 by hkhalil. https://codereview.chromium.org/202073003/ Fix SpdyFramerTest.ProcessDataFrameWithPadding so it no longer tells SpdyFramer to read past the end of a buffer. This lands server change 62728542 by elving. https://codereview.chromium.org/197863004/ Added OverwriteFlags method to SpdyFrameBuilder. If we find the after-compression payload of a HEADERS or PUSH_PROMISE is too long, we can go back and turn off the END_HEADERS or END_PUSH_PROMISE flag. Will be used in a follow-up CL to automatically serialize header blocks across CONTINUATION frames as needed. This lands server change 62682641 by mlavan. https://codereview.chromium.org/202063002/ Update SPDY4 length field to exclude frame prefix length. Does not enforce the new 16KB max frame size. This lands server change 62559133 by mlavan. https://codereview.chromium.org/202033002/ Implement padding for SPDY4/HTTP2 DATA frames. Padding is correctly interpreted, but not emitted. This lands server change 62555297 by raullenchai. https://codereview.chromium.org/199843005/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260477

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Sync and rebase. Back out commits included for trybot benefit, but separately landed upstream. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1118 lines, -406 lines) Patch
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_frame_builder.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/spdy/spdy_frame_builder.cc View 1 2 3 4 5 5 chunks +28 lines, -14 lines 0 comments Download
M net/spdy/spdy_frame_builder_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.h View 1 2 3 4 5 6 chunks +20 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 3 4 5 83 chunks +335 lines, -186 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 3 4 5 63 chunks +330 lines, -180 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 2 3 4 5 6 chunks +83 lines, -11 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 1 chunk +282 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Ryan Hamilton
LGTM, as I have reviewed all the individual changes.
6 years, 9 months ago (2014-03-18 16:15:46 UTC) #1
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 9 months ago (2014-03-27 22:27:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/202403002/130001
6 years, 9 months ago (2014-03-27 22:29:21 UTC) #3
Johnny
The CQ bit was unchecked by jgraettinger@chromium.org
6 years, 9 months ago (2014-03-28 14:55:41 UTC) #4
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 9 months ago (2014-03-28 14:55:49 UTC) #5
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:52:49 UTC) #6
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:55:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/202403002/130001
6 years, 8 months ago (2014-03-30 16:55:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 17:48:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290968
6 years, 8 months ago (2014-03-30 17:48:22 UTC) #10
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 8 months ago (2014-03-30 22:54:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/202403002/130001
6 years, 8 months ago (2014-03-30 22:54:23 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 00:49:05 UTC) #13
Message was sent while issue was closed.
Change committed as 260477

Powered by Google App Engine
This is Rietveld 408576698