Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024013002: Remove asserts inserted to diagnose bug 537922 (Closed)

Created:
4 years, 6 months ago by haraken
Modified:
4 years, 6 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove asserts inserted to diagnose bug 537922 The assert is no longer hit in WebGL conformance tests. It seems that the bug is already fixed. BUG=537922 Committed: https://crrev.com/555450f0886df83589db6224d40425a2f54396f9 Cr-Commit-Position: refs/heads/master@{#398225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
haraken
PTAL
4 years, 6 months ago (2016-05-31 04:59:34 UTC) #2
sof
lgtm
4 years, 6 months ago (2016-05-31 05:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024013002/1
4 years, 6 months ago (2016-05-31 05:44:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78920)
4 years, 6 months ago (2016-05-31 07:32:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024013002/1
4 years, 6 months ago (2016-05-31 09:24:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/78966)
4 years, 6 months ago (2016-05-31 11:18:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024013002/1
4 years, 6 months ago (2016-06-07 02:10:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 04:34:18 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 04:35:40 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/555450f0886df83589db6224d40425a2f54396f9
Cr-Commit-Position: refs/heads/master@{#398225}

Powered by Google App Engine
This is Rietveld 408576698