Add GetTextDirection to ui::TextInputClient API.

Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. As a result clients have no way but to recompute the text direction every
time from the text. This CL adds a GetTextDirection method to TextInputClient to
get the current text direction.

BUG=618184
Committed: https://crrev.com/853189795fc2ac4170c34ff41037b0b76281f1ee
Cr-Commit-Position: refs/heads/master@{#399651}

[karandeepb, 2016-05-31 08:01:00]

Description was changed from

==========
Add GetTextDirection to ui::TextInputClient API.
==========

to

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. This CL adds a GetTextDirection method to TextInputClient to get the
current text direction.

BUG=NONE
==========

[karandeepb, 2016-05-31 08:01:24]

Description was changed from

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. This CL adds a GetTextDirection method to TextInputClient to get the
current text direction.

BUG=NONE
==========

to

==========
TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. This CL adds a GetTextDirection method to TextInputClient to get the
current text direction.

BUG=NONE
==========

[karandeepb, 2016-05-31 08:03:46]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-05-31 09:44:46]

karandeepb@chromium.org changed reviewers:
+ shuchen@chromium.org

[karandeepb, 2016-05-31 09:44:47]

PTAL shuchen@ for ui/base/ime. Do you think this API change is a good idea? As
TextInputClient does not provide a GetTextDirection method, clients have no way
but to recompute it every time, e.g. -
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/cocoa/bri....

[Shu Chen, 2016-05-31 12:35:57]

shuchen@chromium.org changed reviewers:
+ suzhe@chromium.org

[Shu Chen, 2016-05-31 12:35:58]

+suzhe@ who originally designed the interface.

I think the interface is majorly used by ui::InputMethod implementations.
Maybe some input methods are interested in the text direction so this can be
leveraged in the future.

James, what do you think?

[karandeepb, 2016-06-09 01:11:09]

Description was changed from

==========
TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. This CL adds a GetTextDirection method to TextInputClient to get the
current text direction.

BUG=NONE
==========

to

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. As a result clients have no way but to recompute the text direction every
time from the text. This CL adds a GetTextDirection method to TextInputClient to

get the current text direction.

BUG=618184
==========

[karandeepb, 2016-06-09 03:46:42]

karandeepb@chromium.org changed reviewers:
+ jochen@chromium.org, sky@chromium.org

[karandeepb, 2016-06-09 03:46:42]

ping suzhe@.
+sky@ for ui/ review.
+jochen@ for components/ and content/ review.

[sky, 2016-06-09 17:23:53]

LGTM

[karandeepb, 2016-06-10 08:17:12]

ping suzhe@ and jochen@.

[jochen (gone - plz use gerrit), 2016-06-13 15:25:03]

lgtm

[karandeepb, 2016-06-14 02:44:38]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-06-14 02:44:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024003002/40001

[James Su, 2016-06-14 02:58:03]

lgtm

[commit-bot: I haz the power, 2016-06-14 06:29:55]

Description was changed from

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. As a result clients have no way but to recompute the text direction every
time from the text. This CL adds a GetTextDirection method to TextInputClient to

get the current text direction.

BUG=618184
==========

to

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. As a result clients have no way but to recompute the text direction every
time from the text. This CL adds a GetTextDirection method to TextInputClient to

get the current text direction.

BUG=618184
==========

[commit-bot: I haz the power, 2016-06-14 06:29:58]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-14 06:30:07]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 06:33:36]

Description was changed from

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. As a result clients have no way but to recompute the text direction every
time from the text. This CL adds a GetTextDirection method to TextInputClient to

get the current text direction.

BUG=618184
==========

to

==========
Add GetTextDirection to ui::TextInputClient API.

TextInputClient supports forcing a particular TextDirection via
ChangeTextDirectionAndLayoutAlignment, but has no method for retreiving the
same. As a result clients have no way but to recompute the text direction every
time from the text. This CL adds a GetTextDirection method to TextInputClient to
get the current text direction.

BUG=618184

Committed: https://crrev.com/853189795fc2ac4170c34ff41037b0b76281f1ee
Cr-Commit-Position: refs/heads/master@{#399651}
==========

[commit-bot: I haz the power, 2016-06-14 06:33:37]

Patchset 2 (id:??) landed as
https://crrev.com/853189795fc2ac4170c34ff41037b0b76281f1ee
Cr-Commit-Position: refs/heads/master@{#399651}