Add ExceptionBarrier to module scanning in the hope of reducing some false po...

Add ExceptionBarrier to module scanning in the hope of reducing some false positives.

BUG=43343
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46683

[tommi (sloooow) - chröme, 2010-05-06 21:47:42]

http://codereview.chromium.org/2024003/diff/1/2
File chrome_frame/module_utils.cc (right):

http://codereview.chromium.org/2024003/diff/1/2#newcode80
chrome_frame/module_utils.cc:80: ExceptionBarrier exception_barrier;
would it make sense to keep the scope of the exception barrier smaller?  I.e.
only for the outgoing calls?

http://codereview.chromium.org/2024003/diff/1/2#newcode87
chrome_frame/module_utils.cc:87: MODULEENTRY32W module_entry;
suggest we also zero out this struct.

http://codereview.chromium.org/2024003/diff/1/2#newcode95
chrome_frame/module_utils.cc:95: cont = Module32NextW(snapshot, &module_entry);
also initialize and zero out this one prior to this call.

[robertshield, 2010-05-07 13:42:55]

Done, thanks. TBRing for now, to make it easier to do the rest of the work.

http://codereview.chromium.org/2024003/diff/1/2
File chrome_frame/module_utils.cc (right):

http://codereview.chromium.org/2024003/diff/1/2#newcode80
chrome_frame/module_utils.cc:80: ExceptionBarrier exception_barrier;
On 2010/05/06 21:47:43, tommi wrote:
> would it make sense to keep the scope of the exception barrier smaller?  I.e.
> only for the outgoing calls?

Yeah, it would let us know if there are other patched api calls that our veh
will pick up on. Done.

http://codereview.chromium.org/2024003/diff/1/2#newcode87
chrome_frame/module_utils.cc:87: MODULEENTRY32W module_entry;
On 2010/05/06 21:47:43, tommi wrote:
> suggest we also zero out this struct.

Done, sorry I lost this during some svn tomfoolery.

http://codereview.chromium.org/2024003/diff/1/2#newcode95
chrome_frame/module_utils.cc:95: cont = Module32NextW(snapshot, &module_entry);
On 2010/05/06 21:47:43, tommi wrote:
> also initialize and zero out this one prior to this call.

Done.