Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2023983002: PPC: IC: Eliminate initialization_state as a factor in IC installation. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: IC: Eliminate initialization_state as a factor in IC installation. Port 56d90782a5a97e1854e9564056f45b6374664d75 Original commit message: In Crankshaft, we would install special ICs that didn't need a vector and slot in the MEGAMORPHIC case. This optimization limits our hand against future improvements. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/6790f756f6d579387c9d76e60d76cd9767d1da44 Cr-Commit-Position: refs/heads/master@{#36600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -49 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 5 chunks +12 lines, -24 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 5 chunks +7 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-05-30 20:48:10 UTC) #1
JoranSiu
On 2016/05/30 20:48:10, JaideepBajwa wrote: > PTAL lgtm
4 years, 6 months ago (2016-05-30 20:51:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023983002/1
4 years, 6 months ago (2016-05-30 20:57:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 21:25:17 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 21:27:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6790f756f6d579387c9d76e60d76cd9767d1da44
Cr-Commit-Position: refs/heads/master@{#36600}

Powered by Google App Engine
This is Rietveld 408576698