Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2023943005: Adding missing manifests to gn-built executables (Closed)

Created:
4 years, 6 months ago by brucedawson
Modified:
4 years, 6 months ago
Reviewers:
Hzj_jie, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding missing manifests to gn-built executable Many executables are missing embedded manifest files when built with gn. This causes OS compatibility information to be omitted which can lead to strange behavior. This adds a manifest to it2me_standalone_host_main.exe. BUG=602505 Committed: https://crrev.com/c3f7f1c64c5f4d8f865e5e1b3a4072af8f096734 Cr-Commit-Position: refs/heads/master@{#397011}

Patch Set 1 #

Patch Set 2 : Removed accidental line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
brucedawson
Boilerplate change, PTAL.
4 years, 6 months ago (2016-05-31 18:14:44 UTC) #2
Jamie
+zijiehe, since he knows Windows and GN better than I do.
4 years, 6 months ago (2016-05-31 21:28:59 UTC) #6
Hzj_jie
lgtm Thank you Bruce, this change LGTM.
4 years, 6 months ago (2016-05-31 23:20:26 UTC) #7
Jamie
Rubber-stamp LGTM for committer approval.
4 years, 6 months ago (2016-05-31 23:30:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023943005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023943005/20001
4 years, 6 months ago (2016-05-31 23:33:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 01:21:23 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 01:22:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3f7f1c64c5f4d8f865e5e1b3a4072af8f096734
Cr-Commit-Position: refs/heads/master@{#397011}

Powered by Google App Engine
This is Rietveld 408576698