Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2023943002: Revert of Forward output glitch information from stream WebRTC log (Closed)

Created:
4 years, 6 months ago by ericrk
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, vanellope-cl_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Forward output glitch information from stream WebRTC log (patchset #14 id:320001 of https://codereview.chromium.org/1864483002/ ) Reason for revert: This change broke AudioInputTest.Record on the GPU FYI bots. For example, see https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Debug/builds/5928/steps/audio_unittests%20on%20NVIDIA%20GPU%20on%20Mac%20Retina%20on%20Mac/logs/stdio Confirmed locally that the revert fixes the test failure. Original issue's description: > Forward output glitch information from stream WebRTC log > > * A callback is added as input parameter on AudioManager create stream functions. > * OnLogMessage() function is added to the AudioLog interface. > * The AudioOutputDispatcherImpl gives AudioLog::OnLogMessage() as callback when creating an output stream. > * AudioInputController gives AudioInputController::LogMessage() (new function) as callback when creating an input stream. In this function, the message is passed to AudioInputRendererHost::OnLog(). > * In both input and output cases, the message is then passed to the WebRTC log. > * The Mac input and output streams inform about OS glitches via the callback. > > BUG=610967 > > Committed: https://crrev.com/2b2114872f08a1fcfe2a6fb284b645a8152da85c > Cr-Commit-Position: refs/heads/master@{#396722} TBR=dalecurtis@chromium.org,olka@chromium.org,sievers@chromium.org,slan@chromium.org,xiyuan@chromium.org,grunell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610967 Committed: https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165 Cr-Commit-Position: refs/heads/master@{#396747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -413 lines) Patch
M chromecast/media/audio/cast_audio_manager.h View 1 chunk +4 lines, -8 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/audio_modem/audio_recorder_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/media_internals.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 1 chunk +7 lines, -11 lines 0 comments Download
M media/audio/alsa/audio_manager_alsa.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M media/audio/android/audio_android_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/audio/android/audio_manager_android.h View 1 chunk +7 lines, -14 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 5 chunks +11 lines, -20 lines 0 comments Download
M media/audio/audio_input_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/audio_input_controller.cc View 11 chunks +14 lines, -20 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_logging.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/audio/audio_manager.h View 4 chunks +2 lines, -9 lines 0 comments Download
M media/audio/audio_manager_base.h View 2 chunks +7 lines, -16 lines 0 comments Download
M media/audio/audio_manager_base.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 20 chunks +37 lines, -52 lines 0 comments Download
M media/audio/cras/audio_manager_cras.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/cras/audio_manager_cras.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M media/audio/fake_audio_log_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/fake_audio_manager.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/fake_audio_manager.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.h View 3 chunks +1 line, -6 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M media/audio/mac/audio_auhal_mac_unittest.cc View 4 chunks +5 lines, -19 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 3 chunks +1 line, -6 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 4 chunks +2 lines, -11 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 5 chunks +8 lines, -15 lines 0 comments Download
M media/audio/mock_audio_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +4 lines, -8 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 13 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ericrk
Created Revert of Forward output glitch information from stream WebRTC log
4 years, 6 months ago (2016-05-30 18:13:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023943002/1
4 years, 6 months ago (2016-05-30 18:13:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 18:14:45 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 18:16:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/300d26fd54c04a333186c43a9de4d67695c82165
Cr-Commit-Position: refs/heads/master@{#396747}

Powered by Google App Engine
This is Rietveld 408576698