views/mus: Recreate WindowManagerConnection for each test.

views/mus: Recreate WindowManagerConnection for each test.

A new message-loop is created for each test, and when the message-loop dies
after a test, it takes down the all connections to mojo:mus from
WindowManagerConnection (and other places). So it is necessary to recreate the
WindowManagerConnection for each test.

BUG=none

Committed: https://crrev.com/cf0664e7b1ef30b64cec1774af46ce20e9c68dfe
Cr-Commit-Position: refs/heads/master@{#396949}

[sadrul, 2016-05-30 16:32:20]

sadrul@chromium.org changed reviewers:
+ jonross@chromium.org

[sadrul, 2016-05-30 16:32:21]

(you will also need https://codereview.chromium.org/2023863003/ if you are
running the tests on linux)

[jonross, 2016-05-30 16:49:38]

On 2016/05/30 16:32:21, sadrul wrote:
> (you will also need https://codereview.chromium.org/2023863003/ if you are
> running the tests on linux)

LGTM

[sadrul, 2016-05-30 18:40:05]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-05-30 18:40:06]

+sky@ for owner

[sky, 2016-05-31 18:01:27]

https://codereview.chromium.org/2023933002/diff/40001/ui/views/mus/views_mus_...
File ui/views/mus/views_mus_test_suite.cc (right):

https://codereview.chromium.org/2023933002/diff/40001/ui/views/mus/views_mus_...
ui/views/mus/views_mus_test_suite.cc:51: ~PlatformTestHelperMus() override {
WindowManagerConnection::Reset(); }
Can you make ~WindowManagerConnection also unset itself as the native widget
factory? At a minimum WindowManagerConnection should use a weakptr.

[sadrul, 2016-05-31 18:08:15]

https://codereview.chromium.org/2023933002/diff/40001/ui/views/mus/views_mus_...
File ui/views/mus/views_mus_test_suite.cc (right):

https://codereview.chromium.org/2023933002/diff/40001/ui/views/mus/views_mus_...
ui/views/mus/views_mus_test_suite.cc:51: ~PlatformTestHelperMus() override {
WindowManagerConnection::Reset(); }
On 2016/05/31 18:01:27, sky wrote:
> Can you make ~WindowManagerConnection also unset itself as the native widget
> factory? At a minimum WindowManagerConnection should use a weakptr.

Updated ~WMC to unset the native-widget factory.

[sky, 2016-05-31 20:51:06]

LGTM

[sadrul, 2016-05-31 22:12:51]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-05-31 22:12:52]

The patchset sent to the CQ was uploaded after l-g-t-m from jonross@chromium.org
Link to the patchset: https://codereview.chromium.org/2023933002/#ps80001
(title: "tot-merge")

[commit-bot: I haz the power, 2016-05-31 22:13:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023933002/80001

[commit-bot: I haz the power, 2016-05-31 22:19:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-31 22:21:17]

Description was changed from

==========
views/mus: Recreate WindowManagerConnection for each test.

A new message-loop is created for each test, and when the message-loop dies
after a test, it takes down the all connections to mojo:mus from
WindowManagerConnection (and other places). So it is necessary to recreate the
WindowManagerConnection for each test.

BUG=none
==========

to

==========
views/mus: Recreate WindowManagerConnection for each test.

A new message-loop is created for each test, and when the message-loop dies
after a test, it takes down the all connections to mojo:mus from
WindowManagerConnection (and other places). So it is necessary to recreate the
WindowManagerConnection for each test.

BUG=none

Committed: https://crrev.com/cf0664e7b1ef30b64cec1774af46ce20e9c68dfe
Cr-Commit-Position: refs/heads/master@{#396949}
==========

[commit-bot: I haz the power, 2016-05-31 22:21:18]

Patchset 5 (id:??) landed as
https://crrev.com/cf0664e7b1ef30b64cec1774af46ce20e9c68dfe
Cr-Commit-Position: refs/heads/master@{#396949}