Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 202393003: Restore ttf-thai-tlwg package accidentally deleted in r243506 (Closed)

Created:
6 years, 9 months ago by Dirk Pranke
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Restore ttf-thai-tlwg package accidentally deleted in r243506 Per sbc@, it's possible that this package no longer exists in saucy. If so, we need to figure out where the fonts went and make sure the code checks in content_shell work properly . Perhaps this just needs to be a conditional install. However, the package is still needed on Precise, so restore it for now. R=phajdan.jr@chromium.org, mgiuca@chromium.org, sbc@chromium.org BUG=311902, 353061 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Dirk Pranke
6 years, 9 months ago (2014-03-17 19:25:18 UTC) #1
Paweł Hajdan Jr.
LGTM, thanks!
6 years, 9 months ago (2014-03-17 19:51:14 UTC) #2
Sam Clegg
On 2014/03/17 19:51:14, Paweł Hajdan Jr. wrote: > LGTM, thanks! Hmm.. Looks like this package ...
6 years, 9 months ago (2014-03-17 19:57:02 UTC) #3
Dirk Pranke
On 2014/03/17 19:57:02, Sam Clegg wrote: > On 2014/03/17 19:51:14, Paweł Hajdan Jr. wrote: > ...
6 years, 9 months ago (2014-03-17 19:57:47 UTC) #4
Sam Clegg
On 2014/03/17 19:57:02, Sam Clegg wrote: > On 2014/03/17 19:51:14, Paweł Hajdan Jr. wrote: > ...
6 years, 9 months ago (2014-03-17 19:57:56 UTC) #5
Dirk Pranke
Committed patchset #1 manually as r257483 (presubmit successful).
6 years, 9 months ago (2014-03-17 20:00:54 UTC) #6
Matt Giuca
FYI, I synced past this version on Saucy and was able to compile Chrome just ...
6 years, 9 months ago (2014-03-23 23:06:00 UTC) #7
Dirk Pranke
The package isn't a compile-time dependency, it's a test-time dependency. In other words, things will ...
6 years, 9 months ago (2014-03-24 01:53:22 UTC) #8
Lei Zhang
6 years, 8 months ago (2014-04-03 20:36:25 UTC) #9
Message was sent while issue was closed.
As I mentioned on chromium-dev, the new package name is fonts-thai-tlwg

Powered by Google App Engine
This is Rietveld 408576698