Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2023903003: [WIP] Add WebCore.UseCounter UMA to supercede FeatureObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 void Page::updateAcceleratedCompositingSettings() 458 void Page::updateAcceleratedCompositingSettings()
459 { 459 {
460 for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext() ) { 460 for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext() ) {
461 if (!frame->isLocalFrame()) 461 if (!frame->isLocalFrame())
462 continue; 462 continue;
463 if (FrameView* view = toLocalFrame(frame)->view()) 463 if (FrameView* view = toLocalFrame(frame)->view())
464 view->updateAcceleratedCompositingSettings(); 464 view->updateAcceleratedCompositingSettings();
465 } 465 }
466 } 466 }
467 467
468 void Page::didCommitLoad(LocalFrame* frame) 468 void Page::didCommitLoad()
469 { 469 {
470 useCounter().didCommitLoad();
471 frameHost().visualViewport().sendUMAMetrics();
472 }
473
474 void Page::deprecatedDidCommitFrameLoad(LocalFrame* frame)
475 {
476 // This method can be invoked at surprising times. Most logic probably want s to move
477 // into didCommitLoad.
470 notifyDidCommitLoad(frame); 478 notifyDidCommitLoad(frame);
471 if (m_mainFrame == frame) { 479 if (m_mainFrame == frame) {
472 frame->console().clearMessages(); 480 frame->console().clearMessages();
473 useCounter().didCommitLoad(); 481 useCounter().deprecatedDidCommitFrameLoad();
474 deprecation().clearSuppression(); 482 deprecation().clearSuppression();
475 frameHost().visualViewport().sendUMAMetrics();
476 m_hostsUsingFeatures.updateMeasurementsAndClear(); 483 m_hostsUsingFeatures.updateMeasurementsAndClear();
477 UserGestureIndicator::clearProcessedUserGestureSinceLoad(); 484 UserGestureIndicator::clearProcessedUserGestureSinceLoad();
478 } 485 }
479 } 486 }
480 487
481 void Page::acceptLanguagesChanged() 488 void Page::acceptLanguagesChanged()
482 { 489 {
483 HeapVector<Member<LocalFrame>> frames; 490 HeapVector<Member<LocalFrame>> frames;
484 491
485 // Even though we don't fire an event from here, the LocalDOMWindow's will f ire 492 // Even though we don't fire an event from here, the LocalDOMWindow's will f ire
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 { 580 {
574 } 581 }
575 582
576 Page::PageClients::~PageClients() 583 Page::PageClients::~PageClients()
577 { 584 {
578 } 585 }
579 586
580 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 587 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
581 588
582 } // namespace blink 589 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698