Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2023863003: views/mus: Destroy DeviceDataManager only if WindowManagerConnection owns it. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Destroy DeviceDataManager only if WindowManagerConnection owns it. BUG=none Committed: https://crrev.com/294c74ed33bebf5654bc8791de692d7e0d2f6335 Cr-Commit-Position: refs/heads/master@{#396895}

Patch Set 1 #

Patch Set 2 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M ui/views/mus/window_manager_connection.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sadrul
4 years, 6 months ago (2016-05-30 16:26:31 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-05-31 17:58:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023863003/20001
4 years, 6 months ago (2016-05-31 19:04:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 19:30:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:33:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/294c74ed33bebf5654bc8791de692d7e0d2f6335
Cr-Commit-Position: refs/heads/master@{#396895}

Powered by Google App Engine
This is Rietveld 408576698