Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2023863002: Register deserialized lazy statics. (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Register deserialized lazy statics. Register non-const fields without constant initializers as 'lazy statics' during deserialization. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b0bc802b5cd7a9056ba138e50e8aec72ddf01f35

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 chunk +11 lines, -0 lines 2 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-05-30 13:33:55 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2023863002/diff/1/pkg/compiler/lib/src/serialization/system.dart File pkg/compiler/lib/src/serialization/system.dart (right): https://codereview.chromium.org/2023863002/diff/1/pkg/compiler/lib/src/serialization/system.dart#newcode136 pkg/compiler/lib/src/serialization/system.dart:136: // TODO(johnniwinther): Find a cleaner way to do ...
4 years, 6 months ago (2016-05-31 16:48:11 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as b0bc802b5cd7a9056ba138e50e8aec72ddf01f35 (presubmit successful).
4 years, 6 months ago (2016-06-02 09:24:18 UTC) #5
Johnni Winther
4 years, 6 months ago (2016-06-02 09:25:45 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2023863002/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/system.dart (right):

https://codereview.chromium.org/2023863002/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/system.dart:136: // TODO(johnniwinther): Find
a cleaner way to do this. Maybe
On 2016/05/31 16:48:11, Siggi Cherem (dart-lang) wrote:
> Is this the first call to register something that we have in the serialization
> system? It would be nice to keep it that way. I'm ok submitting this as is,
but
> maybe it is worth investigating the alternatives at this time.

I'll look into it now (I have a solution in mind).

Powered by Google App Engine
This is Rietveld 408576698