[iOS] Upstream physical web classes.

[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799
Committed: https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b
Cr-Commit-Position: refs/heads/master@{#397098}

[sdefresne, 2016-05-30 09:30:51]

sdefresne@chromium.org changed reviewers:
+ asvitkine@google.com, dpranke@chromium.org, noyau@chromium.org,
ortuno@chromium.org, rogerta@chromium.org

[sdefresne, 2016-05-30 09:30:51]

sdefresne@chromium.org changed required reviewers:
+ asvitkine@google.com, dpranke@chromium.org, noyau@chromium.org,
ortuno@chromium.org, rogerta@chromium.org

[sdefresne, 2016-05-30 09:30:52]

noyau: please review all the code.

Missing OWNER reviewers for these files:
    BUILD.gn
    tools/metrics/histograms/histograms.xml

dpranke: need OWNERS approval for //BUILD.gn
asvitkine: need OWNERS approval for //tools/metrics/histograms/histograms.xml

Missing LGTM from OWNERS of dependencies added to DEPS:
    '+device/bluetooth/uribeacon',
    '+google_apis',

ortuno: need OWNERS approval for new DEPS on device/bluetooth/uribeacon
rogerta: need OWNERS approval for new DEPS on google_apis

[noyau (Ping after 24h), 2016-05-30 09:56:39]

https://codereview.chromium.org/2023833002/diff/1/ios/chrome/common/physical_...
File ios/chrome/common/physical_web/DEPS (right):

https://codereview.chromium.org/2023833002/diff/1/ios/chrome/common/physical_...
ios/chrome/common/physical_web/DEPS:1: include_rules = [
This code needs a comment somewhere that it is not used by the Chrome
executable, but by an extension. This is important, as the dependencies brought
in should be limited to the strict minimum, and explains why this code uses
NSURL and NSSession instead of GURL and the Chrome network stack.

[sdefresne, 2016-05-30 10:03:06]

https://codereview.chromium.org/2023833002/diff/1/ios/chrome/common/physical_...
File ios/chrome/common/physical_web/DEPS (right):

https://codereview.chromium.org/2023833002/diff/1/ios/chrome/common/physical_...
ios/chrome/common/physical_web/DEPS:1: include_rules = [
On 2016/05/30 09:56:39, noyau wrote:
> This code needs a comment somewhere that it is not used by the Chrome
> executable, but by an extension. This is important, as the dependencies
brought
> in should be limited to the strict minimum, and explains why this code uses
> NSURL and NSSession instead of GURL and the Chrome network stack.

Done.

[noyau (Ping after 24h), 2016-05-30 10:42:43]

The CQ bit was checked by noyau@chromium.org

[noyau (Ping after 24h), 2016-05-30 10:42:44]

lgtm

[commit-bot: I haz the power, 2016-05-30 10:42:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023833002/20001

[commit-bot: I haz the power, 2016-05-30 10:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 10:42:54]

All required reviewers (with asterisk prefixes) have not yet approved this CL.

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Alexei Svitkine (slow), 2016-05-30 14:33:59]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-05-30 14:34:00]

histograms lgtm

[Roger Tawa OOO till Jul 10th, 2016-05-30 17:27:39]

lgtm google_apis deps

[ortuno, 2016-05-31 14:31:38]

lgtm

[sdefresne, 2016-05-31 14:44:17]

Description was changed from

==========
[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799
==========

to

==========
[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799
==========

[sdefresne, 2016-05-31 14:44:18]

sdefresne@chromium.org changed reviewers:
- asvitkine@google.com

[sdefresne, 2016-05-31 14:44:18]

sdefresne@chromium.org changed required reviewers:
+ asvitkine@chromium.org
- asvitkine@google.com

[Dirk Pranke, 2016-05-31 20:00:41]

lgtm.

[sdefresne, 2016-06-01 07:54:57]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-06-01 07:55:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023833002/20001

[commit-bot: I haz the power, 2016-06-01 10:40:26]

Description was changed from

==========
[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799
==========

to

==========
[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799
==========

[commit-bot: I haz the power, 2016-06-01 10:40:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 10:42:50]

Description was changed from

==========
[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799
==========

to

==========
[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799

Committed: https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b
Cr-Commit-Position: refs/heads/master@{#397098}
==========

[commit-bot: I haz the power, 2016-06-01 10:42:51]

Patchset 2 (id:??) landed as
https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b
Cr-Commit-Position: refs/heads/master@{#397098}