Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 202383002: Add settings IDs to SpdyConstants. (Closed)

Created:
6 years, 9 months ago by Johnny
Modified:
6 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add settings IDs to SpdyConstants. Refactor only, no behavioral change. This lands server change 63167890 by hkhalil. BUG=345769

Patch Set 1 #

Patch Set 2 : Add NET_EXPORT_PRIVATE to SpdyConstants. #

Patch Set 3 : Explicit returns for unreachable blocks. #

Patch Set 4 : Test fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -123 lines) Patch
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 4 chunks +14 lines, -19 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 3 6 chunks +72 lines, -87 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M net/spdy/spdy_protocol.h View 1 4 chunks +29 lines, -10 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 2 2 chunks +127 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Johnny
6 years, 9 months ago (2014-03-18 14:53:27 UTC) #1
Ryan Hamilton
6 years, 9 months ago (2014-03-18 16:10:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698