Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2023793002: Move VisibleSelection::nonBoundaryShadowTreeRootNode() to FrameSelection.cpp (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 8 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move VisibleSelection::nonBoundaryShadowTreeRootNode() to FrameSelection.cpp This patch moves a member function |nonBoundaryShadowTreeRootNode()| in |VisibleSelection| to "FrameSelection.cpp", where only the place uses it, to simplify |VisibleSelection| class for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/ed9fa2dc442523095d1cb8dcd2cf21db292adc34 Cr-Commit-Position: refs/heads/master@{#396783}

Patch Set 1 : 2016-05-30T17:24:37 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 8 months ago (2016-05-30 09:18:59 UTC) #3
yoichio
lgtm
4 years, 8 months ago (2016-05-31 01:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023793002/1
4 years, 8 months ago (2016-05-31 03:55:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-05-31 04:25:40 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-05-31 04:26:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed9fa2dc442523095d1cb8dcd2cf21db292adc34
Cr-Commit-Position: refs/heads/master@{#396783}

Powered by Google App Engine
This is Rietveld 408576698