Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2023783002: Fix incorrect sampler locations when using CHROMIUM_bind_uniform_location (Closed)

Created:
4 years, 6 months ago by Kimmo Kinnunen
Modified:
4 years, 6 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix incorrect sampler locations when using CHROMIUM_bind_uniform_location Fix incorrect sampler locations when using CHROMIUM_bind_uniform_location. The extension is not used at the moment, though. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2023783002 Committed: https://skia.googlesource.com/skia/+/3eb7d76b9c3072c33ca8a158bc78ba864521e0f0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/gpu/gl/GrGLUniformHandler.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Kimmo Kinnunen
4 years, 6 months ago (2016-05-30 08:13:08 UTC) #3
egdaniel
lgtm
4 years, 6 months ago (2016-05-30 13:27:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023783002/20001
4 years, 6 months ago (2016-05-31 05:16:09 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 05:30:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3eb7d76b9c3072c33ca8a158bc78ba864521e0f0

Powered by Google App Engine
This is Rietveld 408576698