Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2023763010: [x64] Make xmm0 allocatable and use xmm15 as scratch register instead. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Make xmm0 allocatable and use xmm15 as scratch register instead. The idea is to make it easier (cheaper) to call into C/C++ directly with C calling conventions, which require xmm0 to be used to pass and return floating point values in the future. R=jarin@chromium.org Committed: https://crrev.com/32820ddf9269ac725f0a52b61142462db70374eb Cr-Commit-Position: refs/heads/master@{#36646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -55 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 3 chunks +8 lines, -15 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M src/crankshaft/x64/lithium-gap-resolver-x64.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-01 12:26:30 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-01 12:32:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023763010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023763010/1
4 years, 6 months ago (2016-06-01 12:32:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 13:05:01 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:05:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32820ddf9269ac725f0a52b61142462db70374eb
Cr-Commit-Position: refs/heads/master@{#36646}

Powered by Google App Engine
This is Rietveld 408576698