Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2023763008: Co19 fixes for analyzer and runtime. (Closed)

Created:
4 years, 6 months ago by Paul Berry
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M tests/co19/co19-analyzer2.status View 3 chunks +31 lines, -2 lines 2 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 6 months ago (2016-05-31 17:22:18 UTC) #2
Bill Hesse
LGTM. https://codereview.chromium.org/2023763008/diff/1/tests/co19/co19-analyzer2.status File tests/co19/co19-analyzer2.status (right): https://codereview.chromium.org/2023763008/diff/1/tests/co19/co19-analyzer2.status#newcode406 tests/co19/co19-analyzer2.status:406: Language/Mixins/Mixin_Application/syntax_t11: StaticWarning, CompileTimeError # Issue 26409 I guess ...
4 years, 6 months ago (2016-05-31 17:36:15 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as f54e66777315e188edba01fbb97743257b64916d (presubmit successful).
4 years, 6 months ago (2016-05-31 17:45:23 UTC) #5
Brian Wilkerson
4 years, 6 months ago (2016-05-31 17:58:50 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698