Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: src/bootstrapper.cc

Issue 2023753002: Revert of [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@StringTrim
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/extensions/externalize-string-extension.h" 10 #include "src/extensions/externalize-string-extension.h"
(...skipping 1322 matching lines...) Expand 10 before | Expand all | Expand 10 after
1333 1333
1334 // Install the "constructor" property on the {prototype}. 1334 // Install the "constructor" property on the {prototype}.
1335 JSObject::AddProperty(prototype, factory->constructor_string(), string_fun, 1335 JSObject::AddProperty(prototype, factory->constructor_string(), string_fun,
1336 DONT_ENUM); 1336 DONT_ENUM);
1337 1337
1338 // Install the String.prototype methods. 1338 // Install the String.prototype methods.
1339 SimpleInstallFunction(prototype, "charAt", Builtins::kStringPrototypeCharAt, 1339 SimpleInstallFunction(prototype, "charAt", Builtins::kStringPrototypeCharAt,
1340 1, true); 1340 1, true);
1341 SimpleInstallFunction(prototype, "charCodeAt", 1341 SimpleInstallFunction(prototype, "charCodeAt",
1342 Builtins::kStringPrototypeCharCodeAt, 1, true); 1342 Builtins::kStringPrototypeCharCodeAt, 1, true);
1343 // TODO(bmeurer): One day we will want to install the correct i18n functions
1344 // here directly instead of first installing the dummy, and overriding those
1345 // in i18n.js later.
1346 SimpleInstallFunction(prototype, "toLocaleLowerCase",
1347 Builtins::kStringPrototypeToLowerCase, 0, false);
1348 SimpleInstallFunction(prototype, "toLocaleUpperCase",
1349 Builtins::kStringPrototypeToUpperCase, 0, false);
1350 SimpleInstallFunction(prototype, "toLowerCase",
1351 Builtins::kStringPrototypeToLowerCase, 0, false);
1352 SimpleInstallFunction(prototype, "toUpperCase",
1353 Builtins::kStringPrototypeToUpperCase, 0, false);
1354 SimpleInstallFunction(prototype, "trim", Builtins::kStringPrototypeTrim, 0, 1343 SimpleInstallFunction(prototype, "trim", Builtins::kStringPrototypeTrim, 0,
1355 false); 1344 false);
1356 SimpleInstallFunction(prototype, "trimLeft", 1345 SimpleInstallFunction(prototype, "trimLeft",
1357 Builtins::kStringPrototypeTrimLeft, 0, false); 1346 Builtins::kStringPrototypeTrimLeft, 0, false);
1358 SimpleInstallFunction(prototype, "trimRight", 1347 SimpleInstallFunction(prototype, "trimRight",
1359 Builtins::kStringPrototypeTrimRight, 0, false); 1348 Builtins::kStringPrototypeTrimRight, 0, false);
1360 } 1349 }
1361 1350
1362 { 1351 {
1363 // --- S y m b o l --- 1352 // --- S y m b o l ---
(...skipping 2442 matching lines...) Expand 10 before | Expand all | Expand 10 after
3806 } 3795 }
3807 3796
3808 3797
3809 // Called when the top-level V8 mutex is destroyed. 3798 // Called when the top-level V8 mutex is destroyed.
3810 void Bootstrapper::FreeThreadResources() { 3799 void Bootstrapper::FreeThreadResources() {
3811 DCHECK(!IsActive()); 3800 DCHECK(!IsActive());
3812 } 3801 }
3813 3802
3814 } // namespace internal 3803 } // namespace internal
3815 } // namespace v8 3804 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698