Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2023753002: Revert of [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@StringTrim
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. (patchset #2 id:20001 of https://codereview.chromium.org/2018983002/ ) Reason for revert: Please rebase blink first (if intended): https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7092 Original issue's description: > [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++. > > These builtins always call into C++ anyways and so there's no point in > having the JavaScript wrapper around them, but instead they can be > implemented as C++ builtins directly. > > R=franzih@chromium.org > BUG=v8:5049 > > Committed: https://crrev.com/4e66888869bf04c73b41e5747e4595747a7b20df > Cr-Commit-Position: refs/heads/master@{#36569} TBR=franzih@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5049 Committed: https://crrev.com/b951f7f8f5c8d028d5cfd33513b8df0febb57215 Cr-Commit-Position: refs/heads/master@{#36572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -348 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/i18n.js View 5 chunks +5 lines, -8 lines 0 comments Download
M src/js/string.js View 2 chunks +36 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -300 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +292 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [builtins] Also migrate String.prototype.toLowerCase/toUpperCase to C++.
4 years, 6 months ago (2016-05-30 07:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023753002/1
4 years, 6 months ago (2016-05-30 07:02:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 07:02:15 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 07:03:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b951f7f8f5c8d028d5cfd33513b8df0febb57215
Cr-Commit-Position: refs/heads/master@{#36572}

Powered by Google App Engine
This is Rietveld 408576698