Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2023683002: Tidy PendingScript (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy PendingScript. No need for a prefinalizer as ScriptLoader is careful to eagerly and explicitly dispose of PendingScripts already. Remove unwanted copy constructor; not needed after PendingScript stopped being a part object. R= BUG= Committed: https://crrev.com/0c0d99080d6ada1fbbf43e2b488accc65f413923 Cr-Commit-Position: refs/heads/master@{#396656}

Patch Set 1 #

Patch Set 2 : make assert more interesting #

Patch Set 3 : remove prefinalizer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 2 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. I realized that the prefinalizer isn't serving a purpose while investigating ...
4 years, 6 months ago (2016-05-28 21:01:49 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-05-29 09:20:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023683002/40001
4 years, 6 months ago (2016-05-29 10:01:01 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-29 10:04:49 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-29 10:05:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c0d99080d6ada1fbbf43e2b488accc65f413923
Cr-Commit-Position: refs/heads/master@{#396656}

Powered by Google App Engine
This is Rietveld 408576698