Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: build/common.gypi

Issue 2023653002: Disable warning 4702: Unreachable code for the WPO/PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handle_verifier
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5510 matching lines...) Expand 10 before | Expand all | Expand 10 after
5521 }, 5521 },
5522 }, 5522 },
5523 }], 5523 }],
5524 ['optimize=="max"', { 5524 ['optimize=="max"', {
5525 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO 5525 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
5526 # builds. Probably anything that this would catch that 5526 # builds. Probably anything that this would catch that
5527 # wouldn't be caught in a normal build isn't going to 5527 # wouldn't be caught in a normal build isn't going to
5528 # actually be a bug, so the incremental value of C4702 for 5528 # actually be a bug, so the incremental value of C4702 for
5529 # PGO builds is likely very small. 5529 # PGO builds is likely very small.
5530 'msvs_disabled_warnings': [ 5530 'msvs_disabled_warnings': [
5531 4702 5531 4702
scottmg 2016/05/28 18:46:43 Why isn't this affecting pdfium on the PGO bot?
Sébastien Marchand 2016/05/28 18:53:50 We're not using optimize=max on the PGO bot, we ke
5532 ], 5532 ],
5533 'msvs_settings': { 5533 'msvs_settings': {
5534 'VCCLCompilerTool': { 5534 'VCCLCompilerTool': {
5535 # 2, optimizeMaxSpeed, Maximize Speed (/O2) 5535 # 2, optimizeMaxSpeed, Maximize Speed (/O2)
5536 'Optimization': '2', 5536 'Optimization': '2',
5537 # 1, favorSpeed - Favor fast code (/Ot) 5537 # 1, favorSpeed - Favor fast code (/Ot)
5538 'FavorSizeOrSpeed': '1', 5538 'FavorSizeOrSpeed': '1',
5539 }, 5539 },
5540 }, 5540 },
5541 # TODO(thakis): Remove clang==0 here, https://crbug.com/598772 5541 # TODO(thakis): Remove clang==0 here, https://crbug.com/598772
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
5646 # TODO(brucedawson): http://crbug.com/554200 4312 is a VS 5646 # TODO(brucedawson): http://crbug.com/554200 4312 is a VS
5647 # 2015 64-bit warning for integer to larger pointer 5647 # 2015 64-bit warning for integer to larger pointer
5648 4312, 5648 4312,
5649 5649
5650 # TODO(brucedawson): http://crbug.com/593448 - C4595 is an 'illegal 5650 # TODO(brucedawson): http://crbug.com/593448 - C4595 is an 'illegal
5651 # inline operator new' warning that is new in VS 2015 Update 2. 5651 # inline operator new' warning that is new in VS 2015 Update 2.
5652 # This is equivalent to clang's no-inline-new-delete warning. 5652 # This is equivalent to clang's no-inline-new-delete warning.
5653 # See http://bugs.icu-project.org/trac/ticket/11122 5653 # See http://bugs.icu-project.org/trac/ticket/11122
5654 4595, 5654 4595,
5655 ], 5655 ],
5656 'conditions': [
5657 ['full_wpo_on_official==1', {
5658 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
5659 # builds. Probably anything that this would catch that
5660 # wouldn't be caught in a normal build isn't going to
5661 # actually be a bug, so the incremental value of C4702 for
5662 # PGO builds is likely very small.
5663 'msvs_disabled_warnings': [
5664 4702
5665 ],
5666 }],
5667 ],
5656 'msvs_settings': { 5668 'msvs_settings': {
5657 'VCCLCompilerTool': { 5669 'VCCLCompilerTool': {
5658 'AdditionalOptions': ['/MP'], 5670 'AdditionalOptions': ['/MP'],
5659 'MinimalRebuild': 'false', 5671 'MinimalRebuild': 'false',
5660 'EnableFunctionLevelLinking': 'true', 5672 'EnableFunctionLevelLinking': 'true',
5661 'RuntimeTypeInfo': 'false', 5673 'RuntimeTypeInfo': 'false',
5662 'WarningLevel': '4', 5674 'WarningLevel': '4',
5663 'WarnAsError': 'true', 5675 'WarnAsError': 'true',
5664 'DebugInformationFormat': '3', 5676 'DebugInformationFormat': '3',
5665 # ExceptionHandling must match _HAS_EXCEPTIONS above. 5677 # ExceptionHandling must match _HAS_EXCEPTIONS above.
(...skipping 634 matching lines...) Expand 10 before | Expand all | Expand 10 after
6300 # settings in target dicts. SYMROOT is a special case, because many other 6312 # settings in target dicts. SYMROOT is a special case, because many other
6301 # Xcode variables depend on it, including variables such as 6313 # Xcode variables depend on it, including variables such as
6302 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6314 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6303 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6315 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6304 # files to appear (when present) in the UI as actual files and not red 6316 # files to appear (when present) in the UI as actual files and not red
6305 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6317 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6306 # and therefore SYMROOT, needs to be set at the project level. 6318 # and therefore SYMROOT, needs to be set at the project level.
6307 'SYMROOT': '<(DEPTH)/xcodebuild', 6319 'SYMROOT': '<(DEPTH)/xcodebuild',
6308 }, 6320 },
6309 } 6321 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698